Bug#688069: liblocale-subcountry-perl: Version checks fail ("our $VERSION" moved before "package Locale::SubCountry")

[Ivan Kohler]

Package: liblocale-subcountry-perl
Version: 1.56-1
Severity: serious
Tags: upstream patch
Justification: (Team) Package maintainer's opinion - package unsuitable for release

$ perl -e 'use Locale::SubCountry 54'
Locale::SubCountry does not define $Locale::SubCountry::VERSION--version check failed at -e line 1.

Sometime after version 1.50, "our $VERSION = 1.xx" was moved to the top of
the code, above any "package" declaration.  It is therefore not declaring
$Locale::SubCountry::VERSION, and previously-working version checks like
"use Locale::SubCountry 1.42" now throw a fatal error.

The patch below adds a "package Locale::SubCountry" to the beginning of the
code.  This seems like typical / best practice for modules, to avoid any
symbol exports from the intial "use" statements from polluting the main::
namespace.



--- SubCountry.pm.ORIG  2012-09-18 13:02:15.702774878 -0700
+++ SubCountry.pm       2012-09-18 13:30:04.351443803 -0700
@@ -314,6 +314,8 @@
 
 #-------------------------------------------------------------------------------
 
+package Locale::SubCountry;
+
 use strict;
 use warnings;
 use locale;



-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages liblocale-subcountry-perl depends on:
ii  perl  5.14.2-13

liblocale-subcountry-perl recommends no packages.

liblocale-subcountry-perl suggests no packages.

-- no debconf information


-- 
Ivan Kohler
President and Head Geek, Freeside Internet Services, Inc.  http://freeside.biz/
Debian GNU/Linux developer  |  CPAN author  |  cat person  |  ski addict