Bug#731109: [RFR] templates://pinto/{pinto.templates}

Christian PERRIER bubulle at debian.org
Sat Dec 14 07:35:27 UTC 2013


Please find, for review, the debconf templates and packages descriptions for the pinto source package.

This review will last from Saturday, December 14, 2013 to Tuesday, December 24, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- pinto.old/debian/pinto.templates	2013-12-02 07:30:02.318756824 +0100
+++ pinto/debian/pinto.templates	2013-12-14 08:11:05.282082181 +0100
@@ -1,17 +1,22 @@
 Template: pinto/adminpassword
 Type: password
 _Description: Pinto web administration password:
- Please provide the password to be created with the "pintoadmin" user.
+ Please choose the password for the "pintoadmin" user.

Let's make it clear this is about *choosing* a password and not
provide one that is already existing.

  .
- This is the username and password you will use to log in to your pinto
- installation after configuration is complete. If you do not provide a
- password, you will have to configure access to pinto yourself.
+ This login/password combination is needed, after installation, to log
+ in Pinto through its web interface.
+ .
+ If this is left empty, you will have to manually configure
+ accounts for Pinto.

Reformulation (and split in two paragraph for readability). Avoid
"your pinto installation" as it might not be "mine". Capitalize "Pinto".

 
 Template: pinto/adminpassword-repeat
 Type: password
-_Description: Password confirmation:
+_Description: Re-enter password to verify:
+ Please enter the same user password again to verify you have typed it
+ correctly.

This is the now standard template for password confirmations (see
Debian installer)

 
 Template: pinto/adminpassword-mismatch
-Type: note
-_Description: The passwords do not match
+Type: error
+_Description: Password input error
+ The two passwords you entered were not the same. Please try again.

Ditto for password mismatch templates. Such templates should be
"error" type rather than "note".

 
--- pinto.old/debian/control	2013-12-02 07:30:02.318756824 +0100
+++ pinto/debian/control	2013-12-14 08:12:13.855930658 +0100
@@ -128,7 +128,8 @@
  Pinto is an application for creating and managing a custom CPAN-like
  repository of Perl modules. The purpose of such a repository is to provide a
  stable, curated stack of dependencies from which you can reliably build,
- test, and deploy your application using the standard Perl tool chain. Pinto
- supports various operations for gathering and managing distribution
+ test, and deploy applications using the standard Perl tool chain.
+ .
+ Pinto supports various operations for gathering and managing distribution
  dependencies within the repository, so that you can control precisely which
- dependencies go into your application.
+ dependencies go into applications.

Just avoid "your application". After all, I guess that such
repositories are not used to develop only one application..:-)


-- 


-------------- next part --------------
Template: pinto/adminpassword
Type: password
_Description: Pinto web administration password:
 Please choose the password for the "pintoadmin" user.
 .
 This login/password combination is needed, after installation, to log
 in Pinto through its web interface.
 .
 If this is left empty, you will have to manually configure
 accounts for Pinto.

Template: pinto/adminpassword-repeat
Type: password
_Description: Re-enter password to verify:
 Please enter the same user password again to verify you have typed it
 correctly.

Template: pinto/adminpassword-mismatch
Type: error
_Description: Password input error
 The two passwords you entered were not the same. Please try again.

-------------- next part --------------
--- pinto.old/debian/pinto.templates	2013-12-02 07:30:02.318756824 +0100
+++ pinto/debian/pinto.templates	2013-12-14 08:11:05.282082181 +0100
@@ -1,17 +1,22 @@
 Template: pinto/adminpassword
 Type: password
 _Description: Pinto web administration password:
- Please provide the password to be created with the "pintoadmin" user.
+ Please choose the password for the "pintoadmin" user.
  .
- This is the username and password you will use to log in to your pinto
- installation after configuration is complete. If you do not provide a
- password, you will have to configure access to pinto yourself.
+ This login/password combination is needed, after installation, to log
+ in Pinto through its web interface.
+ .
+ If this is left empty, you will have to manually configure
+ accounts for Pinto.
 
 Template: pinto/adminpassword-repeat
 Type: password
-_Description: Password confirmation:
+_Description: Re-enter password to verify:
+ Please enter the same user password again to verify you have typed it
+ correctly.
 
 Template: pinto/adminpassword-mismatch
-Type: note
-_Description: The passwords do not match
+Type: error
+_Description: Password input error
+ The two passwords you entered were not the same. Please try again.
 
--- pinto.old/debian/control	2013-12-02 07:30:02.318756824 +0100
+++ pinto/debian/control	2013-12-14 08:12:13.855930658 +0100
@@ -128,7 +128,8 @@
  Pinto is an application for creating and managing a custom CPAN-like
  repository of Perl modules. The purpose of such a repository is to provide a
  stable, curated stack of dependencies from which you can reliably build,
- test, and deploy your application using the standard Perl tool chain. Pinto
- supports various operations for gathering and managing distribution
+ test, and deploy applications using the standard Perl tool chain.
+ .
+ Pinto supports various operations for gathering and managing distribution
  dependencies within the repository, so that you can control precisely which
- dependencies go into your application.
+ dependencies go into applications.
-------------- next part --------------
Source: pinto
Section: perl
Priority: optional
Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
Uploaders: Oleg Gashev <oleg at gashev.net>
Build-Depends: debhelper (>= 8),
 libmodule-build-perl (>= 0.400500) | perl (>= 5.19.1)
Build-Depends-Indep: cpanminus (>= 1.6916),
 libapache-htpasswd-perl,
 libapp-cmd-perl,
 libarchive-extract-perl,
 libauthen-simple-passwd-perl,
 libcapture-tiny-perl,
 libclass-load-perl,
 libcpan-checksums-perl,
 libcpan-distnameinfo-perl,
 libcwd-guard-perl,
 libdatetime-perl,
 libdatetime-timezone-perl,
 libdbd-sqlite3-perl (>= 1.33),
 libdbix-class-perl (>= 0.08200),
 libdevel-stacktrace-perl,
 libdist-metadata-perl (>= 0.924),
 libfile-homedir-perl,
 libfile-nfslock-perl,
 libfile-which-perl,
 libhttp-body-perl,
 libhttp-date-perl,
 libhttp-message-perl,
 libio-interactive-perl,
 libio-prompt-perl,
 libio-string-perl,
 libjson-perl,
 liblist-moreutils-perl,
 libmodule-build-cleaninstall-perl,
 perl (>= 5.18.0) | libmodule-corelist-perl (>= 2.89),
 libmodule-faker-perl,
 libmoose-perl,
 libmoosex-aliases-perl,
 libmoosex-classattribute-perl,
 libmoosex-configuration-perl,
 libmoosex-markasmethods-perl,
 libmoosex-nonmoose-perl,
 libmoosex-setonce-perl,
 libmoosex-strictconstructor-perl,
 libmoosex-types-perl,
 libpackage-locator-perl,
 libpath-class-perl,
 libplack-perl (>= 1.0028),
 libproc-fork-perl,
 libproc-terminator-perl,
 libreadonly-perl,
 librouter-simple-perl,
 libstring-format-perl,
 libterm-editoredit-perl,
 libtest-exception-perl,
 libtest-file-perl,
 libtest-lwp-useragent-perl,
 libtest-tcp-perl,
 libtest-warn-perl,
 libthrowable-perl (>= 0.200005),
 libtry-tiny-perl,
 liburi-perl,
 libuuid-tiny-perl,
 libwww-perl,
 starman (>= 0.3014)
Standards-Version: 3.9.4
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/pinto.git
Vcs-Git: git://anonscm.debian.org/pkg-perl/packages/pinto.git
Homepage: https://metacpan.org/release/Pinto/

Package: pinto
Architecture: all
Depends: ${misc:Depends}, ${perl:Depends},
 adduser,
 apache2-utils,
 libapp-cmd-perl,
 libarchive-extract-perl,
 libauthen-simple-passwd-perl,
 libclass-load-perl,
 libcpan-checksums-perl,
 libcpan-distnameinfo-perl,
 libcwd-guard-perl,
 libdatetime-perl,
 libdatetime-timezone-perl,
 libdbd-sqlite3-perl (>= 1.33),
 libdbix-class-perl (>= 0.08200),
 libdevel-stacktrace-perl,
 libdist-metadata-perl (>= 0.924),
 libfile-homedir-perl,
 libfile-nfslock-perl,
 libfile-which-perl,
 libhttp-date-perl,
 libhttp-message-perl,
 libio-interactive-perl,
 libio-prompt-perl,
 libio-string-perl,
 libjson-perl,
 perl (>= 5.15.0) | libjson-pp-perl,
 liblist-moreutils-perl,
 perl (>= 5.18.0) | libmodule-corelist-perl (>= 2.89),
 libmoose-perl,
 libmoosex-aliases-perl,
 libmoosex-classattribute-perl,
 libmoosex-configuration-perl,
 libmoosex-markasmethods-perl,
 libmoosex-nonmoose-perl,
 libmoosex-setonce-perl,
 libmoosex-strictconstructor-perl,
 libmoosex-types-perl,
 libpackage-locator-perl,
 libpath-class-perl,
 libplack-perl (>= 1.0028),
 libproc-fork-perl,
 libproc-terminator-perl,
 libreadonly-perl,
 librouter-simple-perl,
 libstring-format-perl,
 libterm-editoredit-perl,
 libthrowable-perl (>= 0.200005),
 libtry-tiny-perl,
 liburi-perl,
 libuuid-tiny-perl,
 libwww-perl,
 starman (>= 0.3014),
 perl (>= 5.11.0)
Description: application for curating a repository of Perl modules
 Pinto is an application for creating and managing a custom CPAN-like
 repository of Perl modules. The purpose of such a repository is to provide a
 stable, curated stack of dependencies from which you can reliably build,
 test, and deploy applications using the standard Perl tool chain.
 .
 Pinto supports various operations for gathering and managing distribution
 dependencies within the repository, so that you can control precisely which
 dependencies go into applications.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20131214/58ff6d2d/attachment-0001.sig>


More information about the pkg-perl-maintainers mailing list