Comments regarding libsereal-decoder-perl_0.31-1_amd64.changes

[gregor herrmann]

On Wed, 27 Mar 2013 10:55:35 +0000, Ansgar Burchardt wrote:

> I think the "parts taken from JSON::XS" and BSD-3-clause bits from this section:
> 
> ----
> Files: lib/Sereal/Decoder.pm
> Copyright:
>  2012-2013, Steffen Mueller <smueller at cpan.org>
>  2012-2013, Yves Orton <yves at cpan.org>
> License: Artistic or GPL-1+ or BSD-3-clause
> Comment: portions taken from JSON::XS,
>  Copyright: 2007-2011, Marc Lehmann <schmorp at schmorp.de>,
>  License: Artistic or GPL-1+
> ----
> 
> refer not only to code in lib/Sereal/Decoder.pm, but rather all files (e.g. the
> BSD-3-clause bit is about snappy/*).

My impression after taking another look is:

- the "parts taken from JSON::XS" comment actually belongs in a new
  "Files: srl_common.h" section because that's the file which takes
  parts from JSON:XS (or is there more?)
- "BSD-3-clause" is indeed wrong here, but IMO it doesn't belong to
  "Files: *" but only to "snappy/*" (where it already is), at least
  I don't see any BSD licensed code anywhere else
 
> The BSD-3-clause license is also no alternative (i.e. no "or"), but parts of
> the code are *only* under the BSD-3-clause license.

Ack.

Thanks for these hints, and sorry for the mistakes!

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Sting: If You Love Somebody Set Them
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20130327/d9f362ea/attachment.pgp>