Bug#708592: libb-perlreq-perl: FTBFS with perl 5.18: hashing updates

[Niko Tyni]

tag 708592 patch
thanks

On Sat, May 18, 2013 at 08:21:13AM +0300, Damyan Ivanov wrote:
> Control: tag -1 - unreproducible
> Control: retitle -1 libb-perlreq-perl: soometimes FTBFS with perl 5.18: hashing updates

> > On Fri, 17 May 2013 00:06:43 +0100, Dominic Hargreaves wrote:
> > > This package FTBFS with perl 5.18 from experimental (in a clean sbuild
> > > session):

> I've done the same several times, and some times it builds ok, some 
> times it fails. Here are a couple of failures
> 
> #   Failed test at t/01-B-PerlReq.t line 48.
> #          got: 'perl(Data/Dumper.pm)'
> #     expected: ''
> # Looks like you failed 1 test of 78.

It's running this under the hood:

  $ perl -Iblib/arch -Iblib/lib perl.req /usr/share/perl/5.18/Exporter.pm
  Use of each() on hash after insertion without resetting hash iterator results in undefined behavior, Perl interpreter: 0x9e7010 at /home/niko/tmp/libb-perlreq-perl-0.82/blib/lib/B/Walker.pm line 122.
  /usr/share/perl/5.18/Exporter.pm syntax OK
  perl(Exporter/Heavy.pm)

which indeed occasionally fails to report the Heavy.pm dependency.

The warning message is pretty clear, and the attached patch seems to help.
-- 
Niko Tyni   ntyni at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-non-deterministic-failures-on-newer-perls.patch
Type: text/x-diff
Size: 1141 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20130518/69e5370f/attachment-0001.patch>