Bug#735968: dh-make-perl: Prints warning about missing pristine-tar even though it is installed

[Axel Beckert]

Hi Ivan,

Ivan Kohler wrote:
> dh-make-perl says:
> 
> W: pristine-tar not available. Please run
> W:     apt-get install pristine-tar
> W:  followed by
> Use of uninitialized value $tarball in concatenation (.) or string at /usr/share/perl5/DhMakePerl/Command/make.pm line 762.
> W:     pristine-tar commit  upstream/0.08
> 
> It is already installed.

Thanks. A first glance at the problem reveals the following:

    752     if ( File::Which::which('pristine-tar') and $tarball ) {
    753         $ENV{GIT_DIR} = File::Spec->catdir( $self->main_dir, '.git' );
    754         system( 'pristine-tar', 'commit', $tarball, "upstream/".$self->version ) >= 0
    755             or warn "error running pristine-tar: $!\n";
    756     }
    757     else {
    758         warn "W: pristine-tar not available. Please run\n";
    759         warn "W:     apt-get install pristine-tar\n";
    760         warn "W:  followed by\n";
    761         warn "W:     pristine-tar commit $tarball upstream/"
    762             . $self->version . "\n";
    763     }

This means that this warning also is printed if $tarball is false,
even if pristine-tar is installed. The warning "Use of uninitialized
value $tarball" confirms that this was the cause for the warning.

This leaves the question why $tarball is undefined. It gets passed as
parameter to git_add_debian().

This case seems only to happen if guess_tarball fails, because it
returns undef in that case. It should have printed the message "Trying
<some file name>... not found." in that case, too. But guess_tarball
only checks for .orig.tar.gz, neither for .orig.tar.bz2 nor
.orig.tar.xz nor .orig.tar.lzma. Which is kinda bad, too.

Can you tell us with which perl module and which module version this
happened, so we have an example to check if my conclusions are
correct?

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5