Bug#755317: [rt.cpan.org #97372] Fwd: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures

[Willem Toorop]

> From: gregor herrmann <gregoa at debian.org> To: 755317 at bugs.debian.org Cc: Ondřej Surý <ondrej at debian.org> Subject: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures Date: Sun, 20 Jul 2014 14:39:02 +0200 Control: tag -1 + confirmed On Sat, 19 Jul 2014 20:44:36 +0200, David Suárez wrote:
>> Source: libnet-bonjour-perl
>> Version: 0.96-1
>> Severity: serious
>> Tags: jessie sid
>> User: debian-qa at lists.debian.org
>> Usertags: qa-ftbfs-20140718 qa-ftbfs
>> Justification: FTBFS on amd64
>>
>> Hi,
>>
>> During a rebuild of all packages in sid, your package failed to build on
>> amd64.
>>
>> Relevant part (hopefully):
>>> make[1]: Entering directory '/«PKGBUILDDIR»'
>>> PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
>>> t/1-use.t ......... ok
>>> Use of uninitialized value in uc at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 272.
>>> Use of uninitialized value $_[4] in join or string at /usr/lib/perl5/Net/DNS/RR.pm line 69.
>>> Use of uninitialized value $argument in concatenation (.) or string at /usr/lib/perl5/Net/DNS/RR/AAAA.pm line 75.
>>> in new Net::DNS::RR( type AAAA ttl 3600 address  name server.local ... ) at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 327.
>>> # Looks like you planned 18 tests but ran 15.
>>> # Looks like your test exited with 255 just after 15.
>>> t/2-entry.t ....... 
>>> Dubious, test returned 255 (wstat 65280, 0xff00)
>>> Failed 3/18 subtests 
> 
> Breakage by recent Net::DNS?

Yes, but caused by wrong usage (initializing address with undef value)
by Net::Bonjour.  Here is a patch:

--- lib/Net/Bonjour/Entry.pm.orig	2014-07-21 09:43:40.378946335 -0400
+++ lib/Net/Bonjour/Entry.pm	2014-07-21 09:44:39.011734092 -0400
@@ -324,6 +324,8 @@

 	foreach my $type (qw(A AAAA)) {

+		next unless $self->{'_' . $type};
+
 		my $rr = Net::DNS::RR->new(
 			'type'    => $type,
 			'ttl' 	  => $self->ttl,
@@ -331,7 +333,7 @@
 			'name'    => $self->hostname
 		);

-		push(@addrs, $rr) if $self->{'_' . $type};
+		push(@addrs, $rr);
 	}

 	$packet->push('additional', @addrs);


However since Net::DNS 0.75 also test 7 of Net::Bonjour's
t/4-enterprise.ot fails.  Still looking into that...

Cheers,

-- Willem