Bug#750678: libperl-critic-perl: Subroutines::RequireFinalReturn doesn't know about ellipsis statements

[Jakub Wilk]

Package: libperl-critic-perl
Version: 1.121-1
Severity: minor

Perl (>= 5.12) accepts an ellipsis (“...”) as a placeholder for code 
that you haven't implemented yet. perlcritic complains that a function 
using this statement does not end with “return”, even though the 
function never returns:

$ perlcritic -4 test-ellipsis.pl
Subroutine "f" does not end with "return" at line 6, column 1.  See page 197 of PBP.  (Severity: 4)

Adding “...” to terminal_funcs in Subroutines/RequireFinalReturn.pm 
seems to fix the bug. (But FWIW, ellipsis is not really a function.)


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'experimental')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 3.12.0 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libperl-critic-perl depends on:
ii  libb-keywords-perl        1.13-1
ii  libconfig-tiny-perl       2.20-1
ii  libemail-address-perl     1.903-1
ii  libexception-class-perl   1.38-1
ii  libfile-homedir-perl      1.00-1
ii  libfile-which-perl        1.09-1
ii  libio-string-perl         1.08-3
ii  liblist-moreutils-perl    0.33-2
ii  libmodule-pluggable-perl  5.1-1
ii  libpod-spell-perl         1.15-1
ii  libppi-perl               1.215-1
ii  libppix-regexp-perl       0.036-1
ii  libppix-utilities-perl    1.001000-1
ii  libreadonly-perl          1.04-1
ii  libreadonly-xs-perl       1.05-1
ii  libstring-format-perl     1.17-1
ii  libtask-weaken-perl       1.04-1
ii  perl                      5.18.2-4
ii  perltidy                  20140328-1

-- 
Jakub Wilk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-ellipsis.pl
Type: text/x-perl
Size: 60 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20140605/f6f3366c/attachment.pl>