Bug#752917: dh-make-perl: FTBFS with Perl 5.20: Pod coverage on DhMakePerl::Config

[gregor herrmann]

Control: tag -1 + confirmed

On Fri, 27 Jun 2014 21:51:25 +0300, Niko Tyni wrote:

>   #   Failed test 'Pod coverage on DhMakePerl::Config'
>   #   at t/pod-coverage.t line 26.
>   # Coverage for DhMakePerl::Config is 71.4%, with 2 naked subroutines:
>   #   commands
>   #   options
>   # Looks like you failed 1 test of 24.
>   t/pod-coverage.t .................... 
>   Dubious, test returned 1 (wstat 256, 0x100)
>   Failed 1/24 subtests 
>       (less 2 skipped subtests: 21 okay)
>   t/pod.t ............................. ok
>   t/rules.t ........................... ok
>   t/split_version_relation.t .......... ok
>   
>   Test Summary Report
>   -------------------
>   t/pod-coverage.t                  (Wstat: 256 Tests: 24 Failed: 1)
>     Failed test:  8
>     Non-zero exit status: 1
>   Files=22, Tests=408, 21 wallclock secs ( 0.19 usr  0.01 sys + 17.93 cusr  1.28 csys = 19.41 CPU)
>   Result: FAIL

Interesting that POD coverage changes.

Even more interesting is that "commands" and "options" are no subs
but constants. -- Not sure what do do here ... Except for declaring
them private but this seems a bit silly:

#v+
diff --git a/t/pod-coverage.t b/t/pod-coverage.t
index c3f7102..024c34e 100644
--- a/t/pod-coverage.t
+++ b/t/pod-coverage.t
@@ -24,6 +24,9 @@ SKIP: {
         skip "Command::Packaging needs documenting", 1, if $_ eq 'DhMakePerl::Command::Packaging';
         skip "Command::make needs documenting", 1, if $_ eq 'DhMakePerl::Command::make';
         pod_coverage_ok( $_,
-            { coverage_class => 'Pod::Coverage::CountParents' } );
+            {   coverage_class => 'Pod::Coverage::CountParents',
+                also_private => [qw ( commands options )],
+            }
+        );
     }
 }

#v-

Adding some dummy POD also works:

#v+
=head1 CONSTANTS

=over

=item commands

Used internally.

=item options

Used internally.

=back

#v- 

but this feels also silly.


Another option is to rename them to _options and _commands.
Maybe that's the least silly way out of this.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: Blowin' in the Wind
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 928 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20140627/c331c1f1/attachment.sig>