Bug#742409: [Sereal] 2.06 fails to build on some architectures: (#47)

[gregor herrmann]

On Thu, 15 May 2014 22:49:50 +0200, gregor herrmann wrote:

> > > > Anyway, I pushed this:

> Unfortunately the results are not very encouraging:
> - now -decoder- fails to build on armel and armhf
> - so -encoder- is not built on these architectures
> - and s390x still fails the test suite for the encoder

I remembered that I had a raspbian chroot on my laptop, which is also
armhf, so I could look at the failures more easily, and I came up
with the following patch (on top of 9250534):

#v+
Description: fix some occurances of undeclared variables
Origin: vendor
Forwarded: https://github.com/Sereal/Sereal/issues/47
Author: gregor herrmann <gregoa at debian.org>
Last-Update: 2014-05-16

--- a/srl_decoder.c
+++ b/srl_decoder.c
@@ -857,8 +857,9 @@
 {
     union myfloat val;
 #ifdef __ARM_ARCH
+    U8 tmp[sizeof(double)];
     ASSERT_BUF_SPACE(dec, sizeof(float), " while reading FLOAT");
-    Copy(dec->pos,v.c,sizeof(float),U8);
+    Copy(dec->pos,val.c,sizeof(float),U8);
     val.f= *((float *)tmp);
 #else
     ASSERT_BUF_SPACE(dec, sizeof(float), " while reading FLOAT");
@@ -894,7 +895,7 @@
 #ifdef __ARM_ARCH
     U8 tmp[sizeof(long double)];
     ASSERT_BUF_SPACE(dec, sizeof(long double), " while reading LONG_DOUBLE");
-    Copy(dec->pos,v.c,sizeof(long double),U8);
+    Copy(dec->pos,val.c,sizeof(long double),U8);
     val.ld= *((long double *)tmp);
 #else
     ASSERT_BUF_SPACE(dec, sizeof(long double), " while reading LONG_DOUBLE");
#v-

With this patch, -decoder- builds again in the armhf chroot; but
-encoder- still has tons of test failures when built against the
patched -decoder-; although they look different now?!

(Buildlog attached.)
 

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Ludwig Hirsch: Der General
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libsereal-encoder-perl_2.12-2_amd64.build.xz
Type: application/octet-stream
Size: 1004564 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20140516/4858ffca/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 928 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20140516/4858ffca/attachment-0001.sig>