Bug#769240: libcatalyst-controller-formbuilder-perl: FTBFS in jessie/i386: Tests failures

[Simon McVittie]

On 12/11/14 19:50, Simon McVittie wrote:
> Alternatively, CGI::FormBuilder could be augmented to use something like
> this
> 
>     my @xs;
> 
>     if ($q->can("param_fetch")) {
>       @xs = @{$q->param_fetch('x')};
>     } else {
>       @xs = $q->param('x');
>     }
> 
> at each of the locations where Amitai and I patched it.

Since this is, strictly speaking, a regression in our patched
CGI::FormBuilder, I've prepared a patch that replaces Amitai's 2
patches, and my additional patch in the same style. (See attached,
0003-*.patch.)

The best way to do this upstream would probably be to add a new function
Util::param_multi_valued($cgi_or_compatible, $k) encapsulating that
logic, but that's new API, which seems undesirable to add downstream;
that's also a reasonable argument for not adding
Catalyst::Request::param_fetch unless/until Catalyst upstream say yes, I
suppose.

The attached 0001-*.patch is for Debian's git repo. The patched
libcgi-formbuilder-perl passes its tests in sbuild, and so does
libcatalyst-controller-formbuilder-perl_0.06-2 when given the patched
libcgi-formbuilder-perl as an additional .deb.

    S

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revise-patches-from-previous-release-to-retain-suppo.patch
Type: text/x-patch
Size: 10138 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20141112/82db047b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Avoid-unneeded-warning-from-CGI.pm-4.05-or-newer.patch
Type: text/x-patch
Size: 3294 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20141112/82db047b/attachment-0001.bin>