Bug#795716: [libtest-perl-critic-perl] lintian FTBFS with new version

[Niels Thykier]

On Sun, 16 Aug 2015 15:20:53 +0200 gregor herrmann <gregoa at debian.org>
wrote:
> On Sun, 16 Aug 2015 14:17:14 +0200, Bastien ROUCARIÈS wrote:
> 
> > Package: libtest-perl-critic-perl
> > Version: 1.03-1
> > Severity: serious
> > control: affects -1 lintian
> > 
> > Sid version FTBFS whereas testing work fine see
> > https://jenkins.debian.net/job/lintian-tests_sid/
> 
> That's not an actionable bug report.
> If you can add more information (like what Niels hinted at on IRC), i
> can forward the issue upstream.
> 
> 
> Cheers,
> gregor
> 
> -- 
>  .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
>  : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
>  `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
>    `-   


The symptom is:

"""
> $ perl -Ilib  t/scripts/01-critic/docs-examples.t
> 1..1
>     # Subtest: Critic all code in doc/examples/checks
>     ok - Test::Perl::Critic for "doc/examples/checks/my-vendor/another-check.pm"
>     ok - Test::Perl::Critic for "doc/examples/checks/my-vendor/some-check.pm"
>     1..2
> not ok 1 - No tests run for subtest "Critic all code in doc/examples/checks"
> #   Failed test 'No tests run for subtest "Critic all code in doc/examples/checks"'
> #   at t/scripts/01-critic/docs-examples.t line 47.
> # Looks like you failed 1 test of 1.
"""

We run the all_critic_ok in a subtest like so:

"""
            # all_critic_ok emits its own plan, so run it in a subtest
            # so we can just count it as "one" test.
            subtest "Critic all code in $arg" => sub {
                all_critic_ok($arg);
            };
"""



This seems to be broken by upstream, which is now running all the
"critic_ok" tests in a subprocess (via mce_grep).  This means that
all_critic_ok in total do 0 tests!


Thanks,
~Niels