Bug#764825: pkg-perl-tools: dpt push exits successfully on failures

[Niko Tyni]

Control: found -1 0.20

On Sat, Oct 11, 2014 at 05:21:17PM +0300, Niko Tyni wrote:
> Package: pkg-perl-tools
> Version: 0.19
> 
> dpt push exits with 0 even when pushing fails.
> 
> % dpt push; echo $?
> Permission denied (publickey).
> fatal: Could not read from remote repository.
> 
> Please make sure you have the correct access rights
> and the repository exists.
> 0

This was thought to be fixed in 0.20 with

   [ Damyan Ivanov ]
   * dpt-push: exit with the status of the actual 'git push' command
     (Closes: #764825)

but it still doesn't seem to work:

  % dpt push ; echo $?
  ssh: connect to host git.debian.org port 22: No route to host
  fatal: Could not read from remote repository.
  
  Please make sure you have the correct access rights
  and the repository exists.
  0


The underlying git-push correctly exits with an error:

  % git push origin master; echo $?
  ssh: connect to host git.debian.org port 22: No route to host
  fatal: Could not read from remote repository.
  
  Please make sure you have the correct access rights
  and the repository exists.
  128

Presumably the POD=<<'EOF' part in dpt-push clobbers the exit status.
-- 
Niko Tyni   ntyni at debian.org