Bug#789056: libbiblio-thesaurus-perl: FTBFS with perl 5.22 (CGI build-dep)

[Dominic Hargreaves]

Source: libbiblio-thesaurus-perl
Version: 0.43-1
Severity: important
User: debian-perl at lists.debian.org
Usertags: perl-5.22-transition
Tags: sid stretch

This package FTBFS with perl 5.22 (currently in experimental), since CGI
has been removed from perl core:

#   Failed test 'use Biblio::Thesaurus;'
#   at t/00_simple.t line 7.
#     Tried to use 'Biblio::Thesaurus'.
#     Error:  Can't locate CGI.pm in @INC (you may need to install the CGI module) (@INC contains: /«PKGBUILDDIR»/blib/lib /«PKGBUILDDIR»/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.0 /usr/local/share/perl/5.22.0 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at /«PKGBUILDDIR»/blib/lib/Biblio/Thesaurus.pm line 8.
# BEGIN failed--compilation aborted at /«PKGBUILDDIR»/blib/lib/Biblio/Thesaurus.pm line 8.
# Compilation failed in require at t/00_simple.t line 7.
# BEGIN failed--compilation aborted at t/00_simple.t line 7.
Undefined subroutine &main::thesaurusLoad called at t/00_simple.t line 10.
# Looks like you planned 11 tests but ran 1.
# Looks like you failed 1 test of 1 run.
# Looks like your test exited with 255 just after 1.
t/00_simple.t ..... 
1..11
not ok 1 - use Biblio::Thesaurus;
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 11/11 subtests 

....

Test Summary Report
-------------------
t/00_simple.t   (Wstat: 65280 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 11 tests but ran 1.
t/01_construct.t (Wstat: 65280 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 31 tests but ran 1.
t/02_empty.t    (Wstat: 65280 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 6 tests but ran 1.
t/03_toHash.t   (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/10_join.t     (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 13 tests but ran 0.
t/11_multiload.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 2 tests but ran 0.
t/90_big.t      (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 205 tests but ran 0.
Files=9, Tests=3,  1 wallclock secs ( 0.05 usr  0.05 sys +  0.36 cusr  0.06 csys =  0.52 CPU)
Result: FAIL

The fix is to add (build-)dependencies on

libcgi-pm-perl | perl (<< 5.19)

This bug will become release critical nearer the time of the perl 5.22
migration, expected during the (northern hemisphere) summer.

Cheers,
Dominic.