Bug#801609: license-reconcile: FTBFS: cannot parse file 't/data/example/sample.png'

[Jonas Smedegaard]

Quoting Dominique Dumont (2015-11-01 17:57:41)
> Old licensecheck scanned any file (including binary) when licensecheck 
> was run with either of the following arguments:
> - a single file 
> - one or more files matching a regexp passed to --check option
> 
> On the other hand, licensecheck scanned only files with specific 
> extensions (like .c .h) when licensecheck was run with either of the 
> following arguments:
> - more than one file 
> - a directory 
> 
> Unfortunately, the mime based filter I implemented did break the first 
> use case.
> 
> cme (and probably license-reconcile) needs the second use case which 
> broke when directory scan included unparsable results for binary 
> files.
> 
> Now that I better understand what went on, I can restore the behavior 
> described above while keeping a filter based on mime instead of file 
> extension.
> 
> Jonas, do you agree with this proposal ?

If you mean to *not* apply filter when user has explicitly instructed 
what files to work on (by use of regex), then I am in favor.

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20151101/b2669cbb/attachment.sig>