Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

[gregor herrmann]

On Thu, 25 Aug 2016 20:37:23 +0100, Chris Lamb wrote:

> > I assume the problem that the full (and thereby arbitrary/random)
> > path is includeded/used somewhere and your patch changes this to a
> > path relative to the build directory.
> 
> Exactly. The call to Cwd::abs_path introduces the build directory into
> target:
> 
>   http://i.imgur.com/IYdackI.jpg

[..]
 
> Hope that helps.

It does, thanks :)


Patch applied and ...

... and then the package doesn't build for me, the tests fail with:

   dh_auto_test
    perl Build test --verbose 1

#   Failed test 'use Module::Build::WithXSpp;'
#   at t/001_load.t line 6.
#     Tried to use 'Module::Build::WithXSpp'.
#     Error:  Global symbol "$this" requires explicit package name (did you forget to declare "my $this"?) at /build/libmodule-build-withxspp-perl-0.14/blib/lib/Module/Build/WithXSpp.pm line 232.
# Global symbol "$this" requires explicit package name (did you forget to declare "my $this"?) at /build/libmodule-build-withxspp-perl-0.14/blib/lib/Module/Build/WithXSpp.pm line 235.
# Compilation failed in require at t/001_load.t line 6.
# BEGIN failed--compilation aborted at t/001_load.t line 6.
# Looks like you failed 1 test of 1.
t/001_load.t .. 
1..1
not ok 1 - use Module::Build::WithXSpp;
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/001_load.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.09 cusr  0.00 csys =  0.11 CPU)
Result: FAIL
Failed 1/1 test programs. 1/1 subtests failed.




Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Status Quo: Ol Rag Blues
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 931 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20160826/431a043b/attachment.sig>