Bug#828766: liblucy-perl: please make the build reproducible

Dominique Dumont dod at debian.org
Tue Jul 5 12:15:32 UTC 2016


My C is quite rusted, but, for what it's worth, I've looked at the patch.

As far as I understand qsort doc, you call this function with a array of 
strings (char *), i.e. a char**.

cmpstringp is called with an object from the array, i.e. a void pointer to a 
char *. I don't think dereferecing the pointer is safe.

I think you should call strcmp with :

strcmp( (const char *) p1, (const char *) p2);

I'll let you test this

HTH


-- 
 https://github.com/dod38fr/   -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/  -o-   irc: dod at irc.debian.org



More information about the pkg-perl-maintainers mailing list