Bug#871798: libplack-middleware-session-perl: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

[Dominic Hargreaves]

Source: libplack-middleware-session-perl
Version: 0.30-1
Severity: normal
User: debian-perl at lists.debian.org
Usertags: debhelper-use-unsafe-inc-removal

This package FTBFS when debhelper is changed to not export
PERL_USE_UNSAFE_INC to the build environment. This export was added in
2016 at the same time that '.' was removed from INC by default, to
avoid breakage, but was a temporary change.

As well as allowing us to (eventually) remove this export from debhelper,
fixing this bug in your package will also help upstream, since this
change has been made in perl 5.26 upstream.

Additionally, it's possible that the problem may also exist at runtime
for your package (though from experience this is less likely).

Note that the rebuild testing was against a locally-modified version
of debhelper, but you can get the same effect by setting debhelper
compat level 11 in your package, which also removes the same
export.

For information about how to fix this class of issues, please refer
to the upstream release notes (in particular, 'Script authors' and
'Module Authors'):

http://perldoc.perl.org/perldelta.html#Removal-of-the-current-directory-(%22.%22)-from-%40INC

The relevant build failure logs are below:

ok
Can't locate t/lib/TestSession.pm in @INC (you may need to install the t::lib::TestSession module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/001_basic.t line 13.
BEGIN failed--compilation aborted at t/001_basic.t line 13.
t/001_basic.t .................. 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSessionHash.pm in @INC (you may need to install the t::lib::TestSessionHash module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/001a_basic.t line 12.
BEGIN failed--compilation aborted at t/001a_basic.t line 12.
t/001a_basic.t ................. 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSession.pm in @INC (you may need to install the t::lib::TestSession module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/002_basic_w_cookie.t line 14.
BEGIN failed--compilation aborted at t/002_basic_w_cookie.t line 14.
t/002_basic_w_cookie.t ......... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSessionHash.pm in @INC (you may need to install the t::lib::TestSessionHash module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/002a_basic_w_cookie.t line 13.
BEGIN failed--compilation aborted at t/002a_basic_w_cookie.t line 13.
t/002a_basic_w_cookie.t ........ 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSession.pm in @INC (you may need to install the t::lib::TestSession module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/003_basic_w_file_store.t line 15.
BEGIN failed--compilation aborted at t/003_basic_w_file_store.t line 15.
t/003_basic_w_file_store.t ..... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSessionHash.pm in @INC (you may need to install the t::lib::TestSessionHash module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/003a_basic_w_file_store.t line 14.
BEGIN failed--compilation aborted at t/003a_basic_w_file_store.t line 14.
t/003a_basic_w_file_store.t .... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/004_basic_file_w_customs.t ... skipped: Test requires module 'YAML' but it's not found
t/004a_basic_file_w_customs.t .. skipped: Test requires module 'YAML' but it's not found
Can't locate t/lib/TestSession.pm in @INC (you may need to install the t::lib::TestSession module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/005_basic_w_cache_store.t line 13.
BEGIN failed--compilation aborted at t/005_basic_w_cache_store.t line 13.
t/005_basic_w_cache_store.t .... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSessionHash.pm in @INC (you may need to install the t::lib::TestSessionHash module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/005a_basic_w_cache_store.t line 12.
BEGIN failed--compilation aborted at t/005a_basic_w_cache_store.t line 12.
t/005a_basic_w_cache_store.t ... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/TestSession.pm in @INC (you may need to install the t::lib::TestSession module) (@INC contains: /<<PKGBUILDDIR>>/blib/arch /<<PKGBUILDDIR>>/blib/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/006_basic_w_dbi_store.t line 16.
BEGIN failed--compilation aborted at t/006_basic_w_dbi_store.t line 16.
t/006_basic_w_dbi_store.t ...... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/010_middleware.t ............. 
ok 1
ok 2
ok 3
1..3
ok
t/010a_middleware.t ............ 
ok 1
ok 2
1..2
ok
t/012_streaming.t .............. 
ok 1
ok 2
ok 3 - Found session
ok 4 - Fetched session 3522035877dda5b538935200bf7d168b0c7dc83a
ok 5 - Early data is set
ok 6 - Late data was lost, as late_store was not set
ok 7
ok 8
ok 9 - Fetched session 3522035877dda5b538935200bf7d168b0c7dc83a
ok 10 - Early data is set
ok 11 - Late data was stored
1..11
ok
t/013_cookiestore.t ............ 
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
1..7
ok
t/014_cookie_options.t ......... 
ok 1
ok 2
ok 3
1..3
ok
t/015_cookie_options_mw.t ...... 
ok 1
ok 2
1..2
ok
t/016_cookiestore_w_customs.t .. skipped: Test requires module 'YAML' but it's not found
t/release-pod-syntax.t ......... skipped: these tests are for release candidate testing

Test Summary Report
-------------------
t/001_basic.t                (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/001a_basic.t               (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/002_basic_w_cookie.t       (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/002a_basic_w_cookie.t      (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/003_basic_w_file_store.t   (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/003a_basic_w_file_store.t  (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/005_basic_w_cache_store.t  (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/005a_basic_w_cache_store.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
t/006_basic_w_dbi_store.t    (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=20, Tests=35,  1 wallclock secs ( 0.03 usr  0.02 sys +  1.17 cusr  0.11 csys =  1.33 CPU)
Result: FAIL
Please feel feel free to get in touch with the Debian Perl team at              debian-perl at lists.debian.org if you need any more information or                assistance to fix this issue.              

Cheers,
Dominic.