Bug#872856: equivs: generates invalid install file when filename contains { or }

[Juan Grigera]

Package: equivs
Version: 2.1.0.1
Severity: normal

Dear Maintainer,

I have found that equivs-build generates a debian/install file that fails to escape
characters such as { or } in filenames (e.g. {972ce4c6-7e08-4474-a285-3208198ce6fd}.xpi).

A really simple patch could be: (but not 100% sure of side effects, I havent written
perl in a decade)

--- a/usr/bin/equivs-build
+++ b/usr/bin/equivs-build
@@ -92,6 +92,8 @@ open INSTALL, '>', "$builddir/debian/install" or
   die "Cannot open $builddir/debian/install for writing: $!\n";
 foreach my $target (keys %install_files, keys %create_files, keys %create_links) {
   $target =~ s/ +//g;
+  # escape filenames with {, }
+  $target =~ s/({|})/\\$1/g;
   my $dest;
   my $cnt = 0;
   if ($target =~ m/^(preinst|postinst|prerm|postrm)$/) {


Not sure if there are other special chars to be escaped, but I was just hit by this
bug.

Many thanks,
Juan


-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (450, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages equivs depends on:
ii  debhelper  10.7.2
ii  dpkg-dev   1.18.24
ii  fakeroot   1.21-3.1
ii  make       4.1-9.1
ii  perl       5.26.0-5

equivs recommends no packages.

equivs suggests no packages.

-- no debconf information