Bug#883673: fix build with libcdio 1.0

[Rocky Bernstein]

Dominic - I see you have forked the Perl libcdio code. I have just updated
it with something that provisionally works with
http://rocky.github.io/libcdio-1.1.0rc1.tar.bz2  the current 1.1.0 release
candidate.  That Perl code still needs fixups for (not recent) CD-Text API
changes.

In the last libcdio release, I removed the rather old CD-Text API but we
were stull using that in the Perl bindings.

In general what has to happen is 1.1.0 needs to get out there. Then another
Device::Cdio will be released which uses that and will depend on 1.1.0 (not
1.0.0).

Sorry everyone for all of the hassle. With luck, perhaps this will be the
last set of libcdio stuff I do.


On Wed, Dec 6, 2017 at 7:59 AM, Dominic Hargreaves <dom at earth.li> wrote:

> On Wed, Dec 06, 2017 at 11:46:31AM +0100, Matthias Klose wrote:
> > Package: src:libdevice-cdio-perl
> > Version: 0.4.0-2
> > Severity: serious
> > Tags: sid buster patch
> >
> > One driver is gone upstream.
> >
> > patch at
> > http://launchpadlibrarian.net/348274120/libdevice-cdio-perl_
> 0.4.0-2build1_0.4.0-2ubuntu1.diff.gz
>
> Hi Matthew,
>
> I tried applying this patch (both to the Debian package and to upstream
> git ready for forwarding) but I get the following build failures on sid:
>
> ./perlcdio_wrap.c: In function 'get_cdtext':
> ./perlcdio_wrap.c:2439:14: error: too many arguments to function
> 'cdio_get_cdtex
> t'
>      cdtext = cdio_get_cdtext (p_cdio, (track_t) track);
>               ^~~~~~~~~~~~~~~
> In file included from /usr/include/cdio/cdio.h:62:0,
>                  from ./perlcdio_wrap.c:1562:
> /usr/include/cdio/disc.h:77:13: note: declared here
>    cdtext_t *cdio_get_cdtext (CdIo_t *p_cdio);
>              ^~~~~~~~~~~~~~~
> ./perlcdio_wrap.c:2448:29: warning: passing argument 1 of
> 'cdtext_get_const' makes pointer from integer without a cast
> [-Wint-conversion]
>          if(cdtext_get_const(num,cdtext)) {
>                              ^~~
> In file included from /usr/include/cdio/cdio.h:59:0,
>                  from ./perlcdio_wrap.c:1562:
> /usr/include/cdio/cdtext.h:262:13: note: expected 'const cdtext_t * {aka
> const struct cdtext_s *}' but argument is of type 'int'
>  const char *cdtext_get_const (const cdtext_t *p_cdtext, cdtext_field_t
> field,
>              ^~~~~~~~~~~~~~~~
> ./perlcdio_wrap.c:2448:33: error: incompatible type for argument 2 of
> 'cdtext_get_const'
>          if(cdtext_get_const(num,cdtext)) {
>                                  ^~~~~~
>
> [...]
>
> (full log attached).
>
> Do you have any suggestions about how to resolve this?
>
> Cheers,
> Dominic.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20171206/b189341b/attachment.html>