Bug#851347: libjson-validator-perl: uses deprecated Mojo::Util::slurp, makes libswagger2-perl FTBFS

[Niko Tyni]

Package: libjson-validator-perl
Version: 0.90+dfsg-1
Severity: serious
User: debian-perl at lists.debian.org
Usertags: autopkgtest
Tags: fixed-upstream
Control: affects -1 libswagger2-perl

As noticed by ci.debian.net, libswagger2-perl recently started failing
its test suite on current sid, making it fail to build from source.

 https://ci.debian.net/packages/libs/libswagger2-perl/unstable/amd64/

This was caused by libmojolicious-perl_7.18+dfsg-1, which deprecated
Mojo::Util::slurp in favor of Mojo::File::slurp.

The error really comes from libjson-validator-perl, which isn't
obvious because the deprecation code in Mojo::Util fiddles with
$Carp::CarpLevel. It seems to be fixed upstream in 0.91. Filing this
against libjson-validator-perl at RC level, but if somebody wants to
track these with separate bugs, be my guest.

  not ok 41 - no (unexpected) warnings (via done_testing)
  1..41
  Dubious, test returned 1 (wstat 256, 0x100)
  Failed 1/41 subtests 
  Mojo::Util::slurp is DEPRECATED in favor of Mojo::File::slurp at /<<PKGBUILDDIR>>/blib/lib/Swagger2.pm line 38.
  Mojo::Util::slurp is DEPRECATED in favor of Mojo::File::slurp at /<<PKGBUILDDIR>>/blib/lib/Swagger2.pm line 38.
  Mojo::Util::slurp is DEPRECATED in favor of Mojo::File::slurp at /<<PKGBUILDDIR>>/blib/lib/Swagger2.pm line 38.
  [...]
  Test Summary Report
  -------------------
  t/bodytest.t                        (Wstat: 256 Tests: 41 Failed: 1)
    Failed test:  41
    Non-zero exit status: 1
  t/ensure-swagger-response.t         (Wstat: 256 Tests: 12 Failed: 1)
    Failed test:  12
    Non-zero exit status: 1
  t/formdata.t                        (Wstat: 256 Tests: 15 Failed: 1)
    Failed test:  15
    Non-zero exit status: 1
  t/jv-formats.t                      (Wstat: 0 Tests: 23 Failed: 0)
    TODO passed:   7, 10-11
  t/plugin.t                          (Wstat: 0 Tests: 38 Failed: 0)
    TODO passed:   38
  t/validate-json-schema.t            (Wstat: 256 Tests: 9 Failed: 1)
    Failed test:  9
    Non-zero exit status: 1
 
-- 
Niko Tyni   ntyni at debian.org