Bug#852332: dh-make-perl: DEBFULLNAME and DEBEMAIL should be used with git

[gregor herrmann]

On Tue, 24 Jan 2017 12:55:10 +0000, Dominic Hargreaves wrote:

> > @@ -777,7 +777,7 @@ sub git_add_debian {
> >  
> >      my $git = Git->repository( $self->main_dir );
> >      $git->command( 'add', 'debian' );
> > -    $git->command( 'commit', '-m',
> > +    $git->command( 'commit', '--author', $self->get_developer, '-m',
> >          "Initial packaging by dh-make-perl $VERSION" );
> >      $git->command(
> >          qw( remote add origin ),
> 
> This will indeed create commits with the email and name specified, but
> the committer address will not be overridden which is probably confusing.

Ack.
Maybe setting GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL via
environment variables would work?

> I think I'm leaning towards adding the repo config being the least
> worst option, but I'm not completely sure.

Hm. I'm not convinced ... I tend to think it's the individual's
responsibility to set the git variables for manual git commits, as
usual (using DEBFULLNAME and DEBEMAIL for intial creation of the repo
sounds ok to me, as this happens during package creation and it might
not be completely obvious that this involves automated git commits).


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   BOFH excuse #283:  Lawn mower blade in your fan need sharpening