Bug#852332: dh-make-perl: DEBFULLNAME and DEBEMAIL should be used with git

[Carnë Draug]

On 24 January 2017 at 14:19, Carnë Draug <carandraug+dev at gmail.com> wrote:
> Package: dh-make-perl
> Version: 0.92
> Followup-For: Bug #852332
>
> On 24 January 2017 at 13:15, gregor herrmann <gregoa at debian.org> wrote:
>> On Tue, 24 Jan 2017 12:55:10 +0000, Dominic Hargreaves wrote:
>>
>>> > @@ -777,7 +777,7 @@ sub git_add_debian {
>>> >
>>> >      my $git = Git->repository( $self->main_dir );
>>> >      $git->command( 'add', 'debian' );
>>> > -    $git->command( 'commit', '-m',
>>> > +    $git->command( 'commit', '--author', $self->get_developer, '-m',
>>> >          "Initial packaging by dh-make-perl $VERSION" );
>>> >      $git->command(
>>> >          qw( remote add origin ),
>>>
>>> This will indeed create commits with the email and name specified, but
>>> the committer address will not be overridden which is probably confusing.
>>
>> Ack.
>> Maybe setting GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL via
>> environment variables would work?
>
> There are options to git, not to git commit.  One can use:
>
>     git commit -c "user.name=Foo" -c "user.email=Bar" ...
>
> Which would mean changing DhMakePerl::Command::Packaging to have
> get_email and get_name (which would then also be used by
> get_developer).  I have attached a new patch that does that.
>

That should have been:

    git -c "user.name=Foo" -c "user.email=Bar" commit ...

In the mean time, I have noticed that the commits done automatically
by pristine-tar also need consideration.  Since pristine-tar does not
provide an option to set author, I used %ENV variables in that case.
I have attached a new patch.

Carnë
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DhMakePerl-Command-make-use-author-and-email-informa.patch
Type: text/x-diff
Size: 5500 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20170124/118693ae/attachment.patch>