Bug#862827: licensecheck: MPL check too simple, causes false positives

[Jonas Smedegaard]

Hi Axel,

Quoting Axel Beckert (2017-05-17 15:19:48)
> the attached file is reported by licensecheck as follows:
> 
>   /tmp/dns.h: MPL GPL (v2 or later) (with incorrect FSF address)
> 
> But the only line in which the string "MPL" appears is this line:
> 
>   #define DNS_SE_CHK_NOTIMPL  0x0008
> 
> (The original example with which I ran into that issue is
> https://github.com/gamelinux/passivedns/blob/master/src/dns.h)
> 
> Please check at least that MPL is matched as word and not as simple
> substring, i.e. "\bMPL\b" or similar. But preferable the check should be
> still a little bit more sophisticated than that.

I finally took some time for this issue, and believe to have nailed it: 
Patterns now no longer consist only of abbreviation, but will need at 
least another word in front (either "the", or where applicable "gnu", or 
both), and those abbreviation patterns not part of a larger version 
pattern (like "LGPL" part of "LGPLv2") also now has a \b as stop-gap.  
Ideally the version stuff would be integral to the pattern, but that is 
for a later refactoring - these minor changes should catch most 
annoyances like the one reported, I believe.

3.0.30 was released to CPAN few hours ago, and when reports from 
cpantesters arrive (assuming their are not bad) I'll release to Debian.

Thanks for reporting!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20170706/fa0be1a5/attachment.sig>