Bug#868472: pkg-components: Incorrect usage of doit in dh_components (Dh_Lib)

[Niels Thykier]

Package: pkg-components
Version: 0.8
Severity: important

Hi,

There is bug in dh_components, which is hidden by bug in Dh_lib.  I
intend to fix the latter soon, which will cause issues in
dh_components once that happens.  This bug is here:

>          foreach my $bs ($component_data->build_stages) {
>              my $script = $component_data->script($c, $bs);
>              my $command = "CURDIR=$CWD PACKAGE=$package DH_COMPONENT=$c $script";
>              doit($command);
                    ^^^^^^^^
>          }
[...]
>  # Clean up the old components directory
>  if ($dh{PURGE} or not defined $dh{PURGE}) {
>      doit("rm -rf COMPONENTS");
            ^^^^^^^^^^^^^^^^^^^
>  }

The API of doit intends for it to *not* fork a shell, but the above
only works in a shell call.  In the concrete cases, please:

 1) Replace the first usage with complex_doit, which support this use.

 2) Replace the second usage with "doit('rm', '-fr', 'COMPONENTS');"

Thanks,
~Niels