Bug#865563: libcatmandu-sru-perl FTBFS: test failures

[gregor herrmann]

Control: reassign -1 libmodule-build-perl 0.422400-1
Control: forwarded -1 https://github.com/Perl-Toolchain-Gang/Module-Build/issues/77
Control: affects src:libcatmandu-sru-perl

On Fri, 23 Jun 2017 21:19:43 +0100, Dominic Hargreaves wrote:

> On Fri, Jun 23, 2017 at 07:43:52PM +0200, gregor herrmann wrote:

> > I didn't have any success when playing with the new $dot_in_inc_code
> > string, seems like the condition is never met. (And to be honest, I
> > don't understand the logic ...) [0]
[..]

> > [0]
> > my $dot_in_inc_code = $INC[-1] eq '.' ? <<'END' : '';
> >     if ($INC[-1] ne '.') {
> >         push @INC, '.';
> >     }
> > END
> > 
> > What also works is reverting the logic:
> > 
> > --- /usr/share/perl5/Module/Build/Base.pm~	2017-06-19 17:25:18.000000000 +0000
> > +++ /usr/share/perl5/Module/Build/Base.pm	2017-06-23 17:42:01.820466942 +0000
> > @@ -1824,7 +1824,7 @@
> >    my $shebang = $self->_startperl;
> >    my $magic_number = $self->magic_number;
> >  
> > -my $dot_in_inc_code = $INC[-1] eq '.' ? <<'END' : '';
> > +my $dot_in_inc_code = $INC[-1] ne '.' ? <<'END' : '';
> >      if ($INC[-1] ne '.') {
> >          push @INC, '.';
> >      }
> > 
> > 
> > Then PERL_USE_UNSAFE_INC is not needed. But testing $INC[-1] ne '.'
> > two times make as little sense to me as first testing eq '.' and then ne '.'
> > ...
> 
> It does rather look like a mistaken attempt to solve this problem, and
> I agree that the logic is a bit odd, but this seems like the patch
> likely to get accepted upstream; can you send this patch to the module
> author?

Done. Cf. the GH issue URL at the top.
 
> I feel like we should try and not diverge further from upstream; that
> seems almost guaranteed to end up with similar issues later.

Ack.

Thanks for looking into this!


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Neal Casal: Raining Straight Down
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20170623/dcf775fc/attachment-0001.sig>