Bug#865563: libcatmandu-sru-perl FTBFS: test failures

[Dominic Hargreaves]

Control: clone -1 -2
Control: reassign -2 cdbs
Control: retitle -2 cdbs: perl Build.PL -I. doesn't have the intended effect

On Tue, Jun 27, 2017 at 01:31:15AM +0200, Jonas Smedegaard wrote:
> Hmm - I guess the special code in Module::Build checks for . only at the 
> _end_ (or beginning?) of the INC list, and the difference of how 
> debhelper and cdbs applies the option affects the order.
> 
> I will adjust the code in CDBS, but I believe that to be only a 
> workaround and it should be fixed in Module::Build (as a patch in 
> Debian, if upstream chooses to dismiss it).

This aspect has nothing to do with Module::Build; it's just that 
you're passing options to perl in an order which causes them to be ignored.

    perl foo.pl -I.

does nothing diferent to

    perl foo.pl

This was just never seen before in sid because we necessarily fixed this
all in a belt-and-braces fashion to minimise breakage at the point of security
disclosure.

So I agree that the fix is to swap the ordering in cdbs so that it
is consistent with cdbs in jessie. That in itself is a long-term
workaround, until the whole perl ecosystem has got away from the
assumption that '.' will be in @INC.

Given that there are only 12 packages it is plausible to just remove
the (not working) workaround and fix those packages instead (the same
issue in debhelper will take a bit more work; see #836110 which I
really ought to get back to).

Note that I make no remark on Module::Build being buggy or not after
the removal of the Debian-specific stuff; I think the consensus upstream
was that the workarounds should be done in the higher level tolls like
the cpan client and packaging helpers rather than in the modules, but
it still seems like they're attempting to keep '.' on @INC and failing...
we'll see what they say in the github issue there.

Cheers,
Dominic.