Bug#856532: Error: Can't locate object method "get_user"

[gregor herrmann]

On Thu, 16 Mar 2017 19:16:41 +0000, Carnë Draug wrote:

> > How about this change?
> >
> > diff --git a/lib/DhMakePerl/Command/Packaging.pm b/lib/DhMakePerl/Command/Packaging.pm
> > index 690740a..c54942b 100644
> > --- a/lib/DhMakePerl/Command/Packaging.pm
> > +++ b/lib/DhMakePerl/Command/Packaging.pm
> > @@ -119,6 +119,12 @@ sub makefile_pl {
> >      return $self->main_file('Makefile.PL');
> >  }
> >
> > +sub get_user {
> > +    my $self = shift;
> > +    my $user = $ENV{LOGNAME} || $ENV{USER};
> > +    return $user;
> > +}
> > +
> >  sub get_email {
> >      my $self = shift;
> >      my $email = $self->cfg->email;
> > @@ -138,7 +144,7 @@ sub get_name {
> >      my $self = shift;
> >
> >      my $name;
> > -    my $user = $ENV{LOGNAME} || $ENV{USER};
> > +    my $user = $self->get_user;
> >      my $pwnam = getpwuid($<);
> >      die "Cannot determine current user\n" unless $pwnam;
> >      if ( defined $ENV{DEBFULLNAME} ) {
> >
> >
> 
> The new function get_user that you proposed sounds good to me.  I
> pushed that change.  Sorry for causing this silly bug.

No worries, and thanks for the fix!

Uploaded, and unblock request filed.
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Tom Waits: Romeo Is Bleeding
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20170316/0c51def5/attachment.sig>