Bug#916662: all_perl_files_ok should skip .git

[Russ Allbery]

Package: libtest-strict-perl
Version: 0.47-1
Severity: normal

Test::Strict::all_perl_files_ok contains hard-coded logic to exclude
CVS and .svn directories, but doesn't skip .git directories.  It does
provide a way to pass in a list of files to skip, but that is applied
as a filter to the list of individual files, so it cannot be used to
skip directories.

This means that if there are Perl files in .git (which may be the case
if one has used dgit from this checkout, since it makes its own private
copy of the unpacked source package), they will be picked up and tested
incorrectly by this module.

The quick fix is that .git should be added to the hard-coded skip list
in the module.  A better, complementary fix would be to move processing
of $Test::Skip::TEST_SKIP into $want_sub in _all_files and use it to
prune directories as well.  I think it's safe to assume this is what the
caller would want if they list a directory in TEST_SKIP.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libtest-strict-perl depends on:
ii  libdevel-cover-perl  1.31-1+b2
ii  perl                 5.28.1-3

libtest-strict-perl recommends no packages.

libtest-strict-perl suggests no packages.

-- no debconf information