Bug#917592: libterm-termkey-perl: FTBFS (failing tests)

[gregor herrmann]

On Sat, 29 Dec 2018 04:57:00 +0000, Niels Thykier wrote:

> > From the debhelper changelog:
> > 
> > debhelper (11.5.4) unstable; urgency=medium
> > 
> >   [ Niels Thykier ]
> >   * Dh_Lib.pm: Reopen stdin to read from /dev/null in doit (and its sibling
> >     functions) to prevent issues when stdin is open in write-only mode
> >     (which is what nohup(1) does).  Thanks to Julian Gilbey for reporting
> >     the issue and providing a sample patch for it as well.
> >     (Closes: #913663)
> > 
> > 
> > Can this be related? (The failing test operate on \*STDIN.)
> > Cc'ing the debhelper bug and debhelper maintainers …
> 
> Hi gregor,
> 
> Indeed, that could be related.
> 
> To confirm it, please consider editing/patching
> lib/Debian/Debhelper/Dh_Lib.pm by finding the "_doit" function and
> commenting out the following line[1]:
> 
> """
> open(STDIN, '<', '/dev/null') or error("redirect STDIN failed: $!");
> """
> 
> If your test starts working again after that has been removed, then we
> confirmed that is the problem.

I copied my sid cowbuilder chroot, installed debhelper there,
commented out the line, and: the tests pass.
 
> Can you elaborate a bit more on what libterm-termkey-perl expects from
> STDIN here?  A tty perhaps?  

Yes, I think so. From the modules description:

    This module provides a light perl wrapper around the `libtermkey'
    library. This library attempts to provide an abstract way to read
    keypress events in terminal-based programs by providing structures that
    describe keys, rather than simply returning raw bytes as read from the
    TTY device.

> Does/did it work under nohup (without the
> debhelper work around to make nohup work)?

Yes, in the same chroot (i.e. with the STDIN redirection commented
out) `TERM=vt100 nohup prove --blib --verbose t/*.t' in d/rules works.
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Uriah Heep: July Morning
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20181229/9135110b/attachment.sig>