Bug#904197: autopkgtest: smoke.t fails in t/load_write_itself.t

[gregor herrmann]

Package: libconfig-model-itself-perl
Version: 2.014-1
Severity: important
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

As first noted by ci.debian.net, libconfig-model-itself-perl fails
its autopkgtests:

t/load_write_itself.t ...... 
ok 1 - compiled
# Running tests in wr_root/load_write_itself
ok 2 - Read Itself::Model and created instance
# Copying models from /usr/share/perl5/Config/Model/models
Copying readonly directory (/usr/share/perl5/Config/Model/models); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Itself); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Backend); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/application.d); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Role); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Utils); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Cookbook); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Tester); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Value); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Manual); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/Tk); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
Copying readonly directory (/usr/share/perl5/Config/Model/system.d); mode of its contents may not be preserved. at t/load_write_itself.t line 38.
ok 3 - Read all models from wr_root/load_write_itself/lib/Config/Model/models
Configuration item 'application:fstab model' has a wrong value:
	reference type does not know 'Fstab'. Expected 'Itself::Application' or 'Itself::CargoElement' or 'Itself::Class' or 'Itself::CommonElement' or 'Itself::CommonElement::Assert' or 'Itself::CommonElement::WarnIfMatch' or 'Itself::ComputedValue' or 'Itself::ConfigAccept' or 'Itself::ConfigReadWrite' or 'Itself::ConfigReadWrite::DefaultLayer' or 'Itself::Element' or 'Itself::MigratedValue' or 'Itself::Model' or 'Itself::NonWarpableElement' or 'Itself::WarpOnlyElement' or 'Itself::WarpValue' or 'Itself::WarpableCargoElement' or 'Itself::WarpableElement'
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 3.
Dubious, test returned 2 (wstat 512, 0x200)
All 3 subtests passed 


It looks like this is caused by the test copying all of
/usr/share/perl5/Config/Model to the test directory, which seems to
be caused by the change to debian/patches/autopkgtest.patch in
3422cc7.


I've pushed a change to debian/patches/autopkgtest.patch to git which
uses _model_dir instead of _cm_dir which looks like this might have
been the intention, and with this change the test passes during build
and during autopkgtest.


Dominique, can you check if I got this right, please?


Cheers,
gregor

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAltTLN9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgb26BAArvkrTaxyBPelCbL0CJW4uerc9pbCW3L2RzgbC3IQqBKBx+SVv0Q7B0ju
6JU0JKe8h2/ehTorOzIXRNbhiOADDpjO5Hi5jF6DlqaMuZmUxuWyEp6sviohmctW
T8RO9w4cHYIZasEJgffEiur2Wk0nYkiRnt6uLhUykYRhsySi0oZ6D0GWV5OM0LSr
Gnhu0s+afHAmMuGGFznl53GKbySWghAjIGxqQrLr04skbdkDcnIZO3xf8LqHW84X
i/R6PohivZ+HU9UPKVqZkV1L4RVWuz2I6nCjKbw3VYqHzYiX0sQWFD6HzuMi96XK
TOLpDgGrU7/jypw+3nS9EjlKeFAcD49Hz/2OcYhJv2MJpsXclnxs8jzVTIVhLkFC
vtV278uR58giU/AZXFZwbeU90iCrZZiEPspgEgy5S0b3QQ3jjt+wd6CtebG6EBBM
luVQ634WptlAKJnQ1XOFgK3g9vWKaN1ZThZ7LPiogw/cBkhDi47j8ltDq8h32xf2
OevrSfYk4RDfsmp02+u6J9ylBeMe5j9cwgMF2KYfkqMnZB7MiKGNyDfMj7mx+iyF
Vzqml8HTjTV2PRE2MPPSREBJEPZ1XysKwgI58hBrHn5L5l24cF+ypCzgJhzbNttz
71qEiLNOk8BpEBPUy/pcPQCu8rjr2ucJxL4U9spwW9MuPBGOLz0=
=17+K
-----END PGP SIGNATURE-----