Bug#897754: frozen-bubble: ftbfs with GCC-8

[Matthias Klose]

Package: src:frozen-bubble
Version: 2.212-8
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/frozen-bubble_2.212-8_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
SCHROOT_GROUP=user42
SCHROOT_SESSION_ID=unstable-amd64-sbuild-f1be4a3c-56c8-44f2-a350-0b7763c12e5a
SCHROOT_UID=1001
SCHROOT_USER=user42
SHELL=/bin/sh
USER=user42

dpkg-buildpackage
-----------------

dpkg-buildpackage: info: source package frozen-bubble
dpkg-buildpackage: info: source version 2.212-8
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Dominique Dumont <dod at debian.org>
 dpkg-source --before-build frozen-bubble-2.212
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build-arch
dh build-arch
   dh_update_autotools_config -a
   dh_auto_configure -a
	perl -I. Build.PL --installdirs vendor --config "optimize=-g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2" --config "ld=x86_64-linux-gnu-gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro"
[Alien::SDL] Testing header(s): iconv.h
[Alien::SDL] Testing header(s): math.h
[Alien::SDL] Testing header(s): SDL.h
[Alien::SDL] Testing header(s): SDL_mixer.h
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Games-FrozenBubble' version '2.212'
   dh_auto_build -a
	perl Build
x86_64-linux-gnu-gcc -I/usr/lib/x86_64-linux-gnu/perl/5.26/CORE -fPIC -g -Wall -Werror -pipe -Iserver -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -lglib-2.0 -Wdate-time -D_FORTIFY_SOURCE=2 -c -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O2 -g -o server/fb-server.o server/fb-server.c
x86_64-linux-gnu-gcc -I/usr/lib/x86_64-linux-gnu/perl/5.26/CORE -fPIC -g -Wall -Werror -pipe -Iserver -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -lglib-2.0 -Wdate-time -D_FORTIFY_SOURCE=2 -c -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O2 -g -o server/log.o server/log.c
server/log.c: In function 'get_current_date':
server/log.c:64:54: error: '%03d' directive output may be truncated writing between 3 and 11 bytes into a region of size between 0 and 49 [-Werror=format-truncation=]
     snprintf(current_date, sizeof(current_date), "%s.%03d", buf, (int)(1000 * (time-seconds)));
                                                      ^~~~
In file included from /usr/include/stdio.h:862,
                 from server/log.c:22:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output between 5 and 62 bytes into a destination of size 50
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
error building server/log.o from 'server/log.c' at /usr/share/perl/5.26/ExtUtils/CBuilder/Base.pm line 174.
dh_auto_build: perl Build returned exit code 1
make: *** [debian/rules:6: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2