Bug#887536: dh-make-perl depends on libemail-address-perl

gregor herrmann gregoa at debian.org
Thu May 24 21:31:22 BST 2018


On Thu, 24 May 2018 19:30:01 +0000, Damyan Ivanov wrote:

> > I created patch with these changes, but I'm not sure if it is correct
> > due to fact that I do not know what that code should do. So it would be
> > needed to properly test these changes.
> > 
> > Anyway, do you really need to parse email address according to RFC2822?
> > And is not (.*) in these cases enough?
> > 
> > Here is patch:
> 
> Thanks.
> 
> FWIW this code is from Nicolas Bamber and deals with filling 
> debian/copyright from the contents of debian/changelog. This is used 
> by 'dh-make-perl refresh' and is probably used in some part of the 
> test suite.
> 
> So I'd say go ahead and apply the patch as it is and either hope that 
> somebody will notice if something broke or add a test that explicitly 
> covers that specific aspect.

Thanks for the review!

I've applied the patch in git now.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Supertramp: C'est Le Bon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20180524/e739d4cf/attachment.sig>


More information about the pkg-perl-maintainers mailing list