Bug#909480: HTTP::Tiny tries to reuse closed connections
Niko Tyni
ntyni at debian.org
Mon Oct 1 20:21:49 BST 2018
Control: clone -1 -2
Control: reassign -1 libhttp-tiny-perl 0.070-1
Control: block -1 with -2
On Sun, Sep 30, 2018 at 09:12:07AM +0200, Xavier wrote:
> Control: severity -1 normal
> Control: tags -1 + patch
> Control: reassign -1 perl-modules-5.26
>
> Sometimes, a closed connection isn't detected by HTTP::Tiny. To
> reproduce the bug, use feersum sources:
>
> $ perl Makefile.PL && make
> $ taskset -c 0 perl -I blib/lib -I blib/arch t/63*
>
> HTTP::Tiny tries to reuse a closed connection.
>
> This little patch fixes the problem:
>
> --- HTTP/Tiny.pm.orig 2018-09-30 09:02:16.674730242 +0200
> +++ HTTP/Tiny.pm 2018-09-30 09:02:43.274353687 +0200
> @@ -647,6 +647,7 @@
> if ( $self->{keep_alive}
> && $known_message_length
> && $response->{protocol} eq 'HTTP/1.1'
> + && $self->connected
> && ($response->{headers}{connection} || '') ne 'close'
> ) {
> $self->{handle} = $handle;
Hi, thanks for digging into this. HTTP::Tiny is also separately
packaged in libhttp-tiny-perl, and this needs to be fixed there
first. Otherwise installing an unfixed libhttp-tiny-perl package
could override a fixed version in perl-modules-5.26.
So cloning and blocking. Could you please take this upstream
(at https://github.com/chansen/p5-http-tiny/issues) yourself,
assuming it's not been fixed between 0.70 and 0.76 ?
--
Niko
More information about the pkg-perl-maintainers
mailing list