Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

[Damyan Ivanov]

-=| gregor herrmann, 14.09.2018 16:08:50 +0200 |=-
> Control: tag -1 + unreproducible
> 
> On Fri, 14 Sep 2018 16:52:38 +0300, Adrian Bunk wrote:
> 
> > Source: libnet-server-mail-perl
> > Version: 0.25-1
> > Severity: serious
> > Tags: ftbfs
> > 
> > https://buildd.debian.org/status/fetch.php?pkg=libnet-server-mail-perl&arch=all&ver=0.25-1&stamp=1536904015&raw=0
> 
> Thanks for the bug report.
>  
> > ...
> > Test Summary Report
> > -------------------
> > t/starttls.t (Wstat: 9 Tests: 3 Failed: 0)
> >   Non-zero wait status: 9
> >   Parse errors: No plan found in TAP output
> > Files=4, Tests=33,  2 wallclock secs ( 0.05 usr  0.04 sys +  0.67 cusr  0.20 csys =  0.96 CPU)
> > Result: FAIL
> > Failed 1/4 test programs. 0/33 subtests failed.
> > make[1]: *** [Makefile:861: test_dynamic] Error 255
> 
> Hm, the package builds for me.
> 
> 
> The buildd failure is:
> 
> # Error: TLS handshake failed SSL connect attempt failed at t/starttls.t line 116.
> # kill 9, 17145 (server)
> t/starttls.t .. 
> ok 1 - Accepted client for Test01: STARTTLS support
> ok 2 - Accepted client for Test02: STARTTLS invalid parameters
> ok 3 - Accepted client for Test03: STARTTLS handshake
> All 3 subtests passed 
> 
> 
> Line 116 in the test is:
> 
>    112	        my $rv =
>    113	          IO::Socket::SSL->start_SSL( $s,
>    114	            SSL_verify_mode => IO::Socket::SSL::SSL_VERIFY_NONE, );
>    115	
>    116	        ( defined $rv && ref $rv eq 'IO::Socket::SSL' )
>    117	          or die "TLS handshake failed >    " . IO::Socket::SSL::errstr();


Building the package several times (sbuild) passes here most of the 
time and then:

# Error: Can't call method "peerhost" on an undefined value at t/starttls.t line
 131.
# kill 9, 28330 (server)
t/starttls.t .. 
ok 1 - Accepted client for Test01: STARTTLS support
ok 2 - Accepted client for Test02: STARTTLS invalid parameters
ok 3 - Accepted client for Test03: STARTTLS handshake
All 3 subtests passed 

Adding
    $SIG{PIPE} = 'IGNORE';
at the start of the test seems to make it pass all the time.

I wonder if this is the correct fix.

-- Damyan