Bug#934100: /usr/share/lintian/checks/pkg-perl/vcs.desc of pkg-perl-tools breaks lintian if LINTIAN_PROFILE=pkg-perl is set in .lintianrc

[Axel Beckert]

Package: pkg-perl-tools,lintian
Version: lintian/2.17.0
Severity: important
File: /usr/share/lintian/checks/pkg-perl/vcs.desc

Since recently, probably since lintian 2.17.0, lintian bails out as
follows for me:

/usr/share/lintian/checks/pkg-perl/vcs.desc does not have exactly one paragraph
        Lintian::CheckScript::new("Lintian::CheckScript", "/usr/share/lintian/checks", "pkg-perl/vcs") called at /usr/share/perl5/Lintian/Profile.pm line 630
        Lintian::Profile::_parse_check(Lintian::Profile=HASH(0x563355ad1b68), "pkg-perl/vcs", "/usr/share/lintian/checks") called at /usr/share/perl5/Lintian/Profile.pm line 621
        Lintian::Profile::_load_check(Lintian::Profile=HASH(0x563355ad1b68), "pkg-perl/main", "pkg-perl/vcs") called at /usr/share/perl5/Lintian/Profile.pm line 490
        Lintian::Profile::__ANON__("enable-tags-from-check", "pkg-perl/vcs") called at /usr/share/perl5/Lintian/Profile.pm line 532
        Lintian::Profile::_enable_tags_from_field(Lintian::Profile=HASH(0x563355ad1b68), "pkg-perl/main", HASH(0x563355ed4908), "enable-tags-from-check", CODE(0x5633561ed6a0), 1) called at /usr/share/perl5/Lintian/Profile.pm line 510
        Lintian::Profile::_read_profile_tags(Lintian::Profile=HASH(0x563355ad1b68), "pkg-perl/main", HASH(0x563355ed4908)) called at /usr/share/perl5/Lintian/Profile.pm line 409
        Lintian::Profile::_read_profile(Lintian::Profile=HASH(0x563355ad1b68), "/usr/share/lintian/profiles/pkg-perl/main.profile") called at /usr/share/perl5/Lintian/Profile.pm line 180
        Lintian::Profile::new("Lintian::Profile", "pkg-perl", ARRAY(0x563353d63ae0), HASH(0x56335409c268)) called at /usr/bin/lintian line 216
        dplint::load_profile("pkg-perl") called at /usr/share/lintian/commands/lintian.pm line 1435
        eval {...} called at /usr/share/lintian/commands/lintian.pm line 1435
        main::load_profile_and_configure_tags() called at /usr/share/lintian/commands/lintian.pm line 653
        main::main() called at /usr/bin/lintian line 46
        eval {...} called at /usr/bin/lintian line 46
        main::__ANON__("/usr/share/lintian/commands/lintian.pm") called at /usr/bin/lintian line 115
        dplint::run_tool("/usr/bin/lintian", "lintian") called at /usr/bin/lintian line 291
        dplint::main() called at /usr/bin/lintian line 362

The first line is probably the relevant one:

  /usr/share/lintian/checks/pkg-perl/vcs.desc does not have exactly one paragraph

And indeed, if I remove or comment out the line

  LINTIAN_PROFILE=pkg-perl

from my .lintianrc, the issue is gone, but so are
debian-perl-team-specific tests.

I suspect this is related to this change in 2.17.0:

  * Store tags is separate, small files under ./tags.

But if so, I'm not sure if breaking lintian profiles was really planned,
so I'm filing this against both, lintian and pkg-perl-tools and
X-Debbugs-Cc'ing Felix Lechner.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages pkg-perl-tools depends on:
ii  curl                           7.65.1-1
ii  debhelper                      12.3
ii  devscripts                     2.19.6
ii  dh-make-perl                   0.106
ii  git                            1:2.23.0~rc1-1
ii  git-buildpackage               0.9.14
ii  libdatetime-perl               2:1.51-1
ii  libdpkg-perl                   1.19.7
ii  libgit-repository-perl         1.323-1
ii  libgitlab-api-v4-perl          0.20-1
ii  libipc-run-perl                20180523.0-1
ii  libjson-xs-perl                4.020-1
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libproc-invokeeditor-perl      1.13-1
ii  librt-client-rest-perl         1:0.56-1
ii  libtry-tiny-perl               0.30-1
ii  libutf8-all-perl               0.024-1
ii  lintian                        2.17.0
ii  openssh-client [ssh-client]    1:8.0p1-4
ii  perl                           5.28.1-6
ii  pristine-tar                   1.46
ii  quilt                          0.65-3

Versions of packages pkg-perl-tools recommends:
ii  autodep8                      0.18
ii  autopkgtest                   5.10
ii  libconfig-model-dpkg-perl     2.125
ii  libconfig-model-perl          2.136-1
ii  libdebian-copyright-perl      0.2-4
ii  libfile-slurp-perl            9999.27-1
ii  libmime-lite-perl             3.030-2
ii  libmodule-inspector-perl      1.05-2
ii  libnet-github-perl            0.95-1
ii  libparallel-forkmanager-perl  2.02-1
ii  libsoap-lite-perl             1.27-1
ii  libterm-readline-gnu-perl     1.36-2
ii  libwww-mechanize-perl         1.91-2
ii  libyaml-libyaml-perl          0.79+repack-2
ii  lintian                       2.17.0
ii  myrepos [mr]                  1.20180726
ii  sensible-utils                0.0.12

Versions of packages pkg-perl-tools suggests:
ii  bc                    1.07.1-2+b2
ii  cdbs                  0.4.159
ii  duck                  0.13
ii  moreutils             0.63-1
ii  perl-depends          2016.1029+git8f67695-1
ii  python3               3.7.3-1
ii  python3-launchpadlib  1.10.7-1

-- no debconf information