Bug#923358: libdist-inkt-perl: Stuffs full path into tarball

[Jonas Smedegaard]

Quoting Niko Tyni (2019-03-02 14:44:38)
> On Sat, Mar 02, 2019 at 01:45:19PM +0100, Jonas Smedegaard wrote:
> > reassign -1 perl
> > retitle -1 perl: breaks libdist-inkt-perl
> > thanks
> 
> I don't think this worked. Presumably you forgot to bcc
> control at bdo.

Yes.


> But never mind that, I think it's libdist-inkt-perl that needs
> to change. See below.

Oh, ok.  I'll cancel my composing a "bts" command, then :-)


> > Quoting Jonas Smedegaard (2019-02-26 22:41:00)
> > > The command distinkt-dist is completely useless: Produces tarballs 
> > > containing full path (not paths relative to build dir), and then 
> > > fails.
> > > 
> > > Upstream bug: https://github.com/tobyink/p5-dist-inkt/issues/3
> > 
> > Seems to be a bug not in libdist-inkt-perl but in recent perl - or one 
> > of the libraries upgraded in lockstep with perl.
> > 
> > Testsuite does not reveal the bug (it is quite minimal).  The following, 
> > however, should prove that the bug is not in libdist-inkt-perl itself, 
> > as it succeeds on stretch but fails on buster:
> > 
> > apt install libfile-chdir-perl libpath-finddev-perl libmoose-perl liblist-moreutils-perl libtype-tiny-perl libtypes-path-tiny-perl libpath-iterator-rule-perl libnamespace-autoclean-perl libdata-dump-perl libsoftware-license-perl libmodule-cpanfile-perl libtext-sprintfn-perl libcpan-changes-perl librdf-doap-lite-perl
> > dget http://deb.debian.org/debian/pool/main/libd/libdist-inkt-perl/libdist-inkt-perl_0.024-4.dsc
> > cd libdist-inkt-perl-0.024/examples/p5-acme-example-dist/
> > PERL5LIB=../../lib perl ../../script/distinkt-dist
> 
> It looks like this is due to this Archive-Tar change:
> 
>   2.28  08/06/2018 (madroach, ARC, OCBNET, ppisar)
>   - allow archiving with absolute pathnames - fixes 97748

Yes, that matches my finding that Dist::Inkt breaks with the commit 
https://github.com/jib/archive-tar-new/commit/a00e0 which landed in 2.28 
and has a commit messages smelling like it is above change indeed.


> Dist::Inkt::BuildTarball() puts absolute file names in the generated
> archive, then renames them to relative ones.
> 
>   $tar->add_files($abs);
>   $tar->rename(substr("$abs", 1), "$pfx/".$abs->relative($root));
> 
> This is relying on Archive::Tar having removed the first slash,
> which is no longer a valid assumption.
> 
> I expect Dist::Inkt needs to adapt. Once that is done, we should
> probably add a Breaks on the perl side for older versions. Please
> file a separate bug about that.

Thanks for the very helpful hints.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20190302/2ba4086d/attachment.sig>