Bug#923824: libdancer2-plugin-database-perl: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:libdancer2-plugin-database-perl
Version: 2.17-1
Severity: important
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep
   dh_update_autotools_config -i
   dh_auto_configure -i
	perl -I. Makefile.PL INSTALLDIRS=vendor "OPTIMIZE=-g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2" "LD=x86_64-linux-gnu-gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro"
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Dancer2::Plugin::Database
Writing MYMETA.yml and MYMETA.json
   dh_auto_build -i
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
cp lib/Dancer2/Plugin/Database.pm blib/lib/Dancer2/Plugin/Database.pm
Manifying 1 pod document
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test -i
	make -j1 test TEST_VERBOSE=1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')" t/*.t
# Testing Dancer2::Plugin::Database 2.17, with Dancer2 0.207000 in Perl 5.028001, /usr/bin/perl
t/00-load.t ....... 
1..1
ok 1 - use Dancer2::Plugin::Database;
ok
#   Failed test 'database_connection_failed hook fires'
#   at t/01-basic.t line 247.
#          got: ''
#     expected: '1'
# Looks like you failed 1 test of 43.
t/01-basic.t ...... 
ok 1 - Got a code ref
ok 2 - database_connected hook fires
ok 3 - database_error hook fires
ok 4 - handle isa('DBI::db')
ok 5 - handle isa('Dancer::Plugin::Database::Core::Handle')
ok 6 - handle isa('t::lib::TestHandleClass')
ok 7 - handle is not a duck
ok 8 - db is created
ok 9 - GET / is found
ok 10 - content looks good for / (7 users afiter DB initialisation)
ok 11 - GET /user/1 is found
ok 12 - content looks good for /user/1
ok 13 - content looks good for /user/2
ok 14 - DELETE /user/3 is ok
ok 15 - content looks good for / (6 users after deleting one)
ok 16 - quick_insert returned OK status
ok 17 - quick_insert created a record successfully
ok 18 - quick_select returned the record created by quick_insert
ok 19 - quick_select doesn't return non-matching record
ok 20 - content looks good for /quick_select/1/category
ok 21 - content looks good for /quick_select/2/name
ok 22 - content looks good for /quick_lookup/bigpresh
ok 23 - quick_count shows 2 admins
ok 24 - Complex where clause succeeded
ok 25 - Complex not where clause succeeded
ok 26 - set operation where clause succeeded
ok 27 - quick_select returns multiple records in list context
ok 28 - quick_update returned OK status
ok 29 - quick_update updated a record successfully
ok 30 - quick_delete returned OK status
ok 31 - quick_delete deleted a record successfully
ok 32 - Fetched a single specified column OK
ok 33 - Fetched multiple specified columns OK
ok 34 - User-specified LIMIT works (1 row)
ok 35 - User-specified LIMIT works (2 row)
ok 36 - Records sorted properly
ok 37 - Records sorted properly in descending order
ok 38
ok 39 - runtime_config returned OK status
ok 40 - runtime_config got a usable database handle
ok 41
ok 42 - database_connection_lost hook fires
not ok 43 - database_connection_failed hook fires
1..43
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/43 subtests 
t/manifest.t ...... skipped: Author tests not required for installation
t/pod-coverage.t .. skipped: Author tests not required for installation
t/pod.t ........... 
1..1
ok 1 - POD test for blib/lib/Dancer2/Plugin/Database.pm
ok

Test Summary Report
-------------------
t/01-basic.t    (Wstat: 256 Tests: 43 Failed: 1)
  Failed test:  43
  Non-zero exit status: 1
Files=5, Tests=45,  4 wallclock secs ( 0.07 usr  0.03 sys +  2.54 cusr  0.27 csys =  2.91 CPU)
Result: FAIL
Failed 1/5 test programs. 1/45 subtests failed.
make[1]: *** [Makefile:851: test_dynamic] Error 255
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: make -j1 test TEST_VERBOSE=1 returned exit code 2
make: *** [debian/rules:4: build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made in one of my autobuilders with "dpkg-buildpackage -A".

The failure happens randomly, i.e. sometimes it fails, sometimes it does not,
so I don't have a "recipe" to reproduce it as such, but the "randomness"
is reproducible in my autobuilders (i.e. when I build it a lot of times,
there are always some failed builds).

I've put several failed build logs here for reference:

https://people.debian.org/~sanvila/build-logs/libdancer2-plugin-database-perl/

If you need a test machine to reproduce this, please contact me
privately and I could provide ssh access to a machine where it happens
(caveat: randomly and maybe with low probability).

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.