Bug#944964: dh-make-perl: Module accesses internal dpkg database

[Damyan Ivanov]

-=| gregor herrmann, 18.11.2019 18:29:36 +0100 |=-
> On Sun, 17 Nov 2019 21:38:24 +0100, Guillem Jover wrote:
> 
> >  [M] lib/Debian/DpkgLists.pm
> > 
> > The function _cat_lists() accesses the file list files directly, and
> > should be switched to use either «dpkg-query --listfiles» instead, or the
> > dpkg-query db-fsys:Files virtual field with --show.
> 
> Thanks for the bug report and the hint about db-fsys:Files.
> 
> I've now come up with a first patch (pushed to git) which seems to
> work and which is not terribly slow.
> 
> t/DpkgLists.t still passes and takes ~9 seconds; with the original
> _cat_lists() it was more like 2.5 seconds but well.
> 
> 
> For convenience, here's the current proposal for _cat_lists():
> <snip>

Looks good to me.

The speed regression is unfortunate, but I see nothing in the new 
implementation that would cause it. (My first thought was that the 
original approach employed parallel processing, but this was not the 
case.)

Thank you, gregor!


-- dam