Bug#942439: libfont-freetype-perl: Regression test failing against FreeType 2.10

[Hugh McMaster]

Package: libfont-freetype-perl
Version: 0.12-1+b2
Severity: important
Tags: patch

Dear Maintainer,

Dear Maintainer,

The logic for computing the global ascender, descender and height of OpenType
fonts was slightly adjusted in FreeType 2.10.

This change is causing regression tests 22, 23 and 24 in libfont-freetype-perl
to fail.

While the Font::FreeType Perl module does actually return the correct values
for the above metrics (as calculated by FreeType), these values do not match
the expected values in the regression tests.

This failure, in turn, is blocking the migration of FreeType 2.10.1 to Testing.

Please apply the below patch to resolve this.

Thank you



-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.2.0-3-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libfont-freetype-perl depends on:
ii  libc6                       2.29-2
ii  libfreetype6                2.10.1-2
ii  perl                        5.30.0-7
ii  perl-base [perlapi-5.30.0]  5.30.0-7

libfont-freetype-perl recommends no packages.

libfont-freetype-perl suggests no packages.

-- no debconf information
-------------- next part --------------
Description: Fix font metrics broken by an upstream FreeType change
 The logic for computing the global ascender, descender and height of OpenType
 fonts was slightly adjusted in FreeType 2.10. This change causes regression
 tests 22, 23 and 24 to fail.

Author: Hugh McMaster <hugh.mcmaster at outlook.com>
Bug: https://rt.cpan.org/Public/Bug/Display.html?id=129788
Last-Update: 2019-10-16

--- libfont-freetype-perl-0.12.orig/t/10metrics_oldstandart.t
+++ libfont-freetype-perl-0.12/t/10metrics_oldstandart.t
@@ -57,9 +57,9 @@ is($font->units_per_em, 1000, '$face->un
 my $underline_position = $font->underline_position;
 ok $underline_position <= -178 || $underline_position >= -198, 'underline position';
 is($font->underline_thickness, 40, 'underline thickness');
-is($font->height, 1482, 'text height');
-is($font->ascender, 952, 'ascender');
-is($font->descender, -294, 'descender');
+is($font->height, 1236, 'text height');
+is($font->ascender, 762, 'ascender');
+is($font->descender, -238, 'descender');
 
 subtest "charmaps" => sub {
     subtest "default charmap" => sub {