Bug#909480: HTTP::Tiny tries to reuse closed connections

[Niko Tyni]

Control: reassign -1 libhttp-tiny-perl

On Mon, Oct 01, 2018 at 10:21:49PM +0300, Niko Tyni wrote:
> Control: clone -1 -2
> Control: reassign -1 libhttp-tiny-perl 0.070-1
> Control: block -1 with -2
> 
> On Sun, Sep 30, 2018 at 09:12:07AM +0200, Xavier wrote:
> > Control: severity -1 normal
> > Control: tags -1 + patch
> > Control: reassign -1 perl-modules-5.26
> > 
> > Sometimes, a closed connection isn't detected by HTTP::Tiny. To
> > reproduce the bug, use feersum sources:
> > 
> > $ perl Makefile.PL && make
> > $ taskset -c 0 perl -I blib/lib -I blib/arch t/63*
> > 
> > HTTP::Tiny tries to reuse a closed connection.
> > 
> > This little patch fixes the problem:
> > 
> > --- HTTP/Tiny.pm.orig        2018-09-30 09:02:16.674730242 +0200
> > +++ HTTP/Tiny.pm     2018-09-30 09:02:43.274353687 +0200
> > @@ -647,6 +647,7 @@
> >      if ( $self->{keep_alive}
> >          && $known_message_length
> >          && $response->{protocol} eq 'HTTP/1.1'
> > +        && $self->connected
> >          && ($response->{headers}{connection} || '') ne 'close'
> >      ) {
> >          $self->{handle} = $handle;
> 
> Hi, thanks for digging into this. HTTP::Tiny is also separately
> packaged in libhttp-tiny-perl, and this needs to be fixed there
> first. Otherwise installing an unfixed libhttp-tiny-perl package
> could override a fixed version in perl-modules-5.26.

I'm not quite clear if there is something to fix in HTTP::Tiny or not.
The original bug got fixed or worked around in feersum, and we now have
a lingering one against perl.

I'm reassigning this one to libhttp-tiny-perl as well. We're not
going to patch the bundled version in src:perl before the separate
version is fixed.
-- 
Niko Tyni   ntyni at debian.org