Bug#968871: dh-make-perl: `--version` option is used as-is for upstream version

[Richard Hansen]

Package: dh-make-perl
Version: 0.113
Severity: normal

Dear Maintainer,

The dh-make-perl(1p) man page says:

    --version VERSION
        Specifies the version of the resulting package. Usually
        calculated correctly but --version can override wrong guesses.

        Note that this is not the upstream version. For a non-native
        package you need to include the Debian revision here, e.g. for
        a new package of upstream's x.y release this would be x.y-1.

However, when I run:

    dh-make-perl --pkg-perl --cpan CGI::Application::Plugin::DebugScreen --version 1.00-1

it uses "1.00-1", not "1.00", for the `upstream/*` tag and pristine tarball name.

(As expected, if I pass `--version 1.00` instead, the upstream tag and orig tarball are correct but the version in the generated `debian/changelog` is 1.00, not 1.00-1.)


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.3.0-62-generic (SMP w/8 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages dh-make-perl depends on:
ii  debhelper                  13.2
ii  dpkg-dev                   1.20.5
ii  fakeroot                   1.24-1
ii  libapt-pkg-perl            0.1.36+b3
ii  libarray-unique-perl       0.08-2
ii  libclass-accessor-perl     0.51-1
ii  libconfig-ini-perl         1:0.025-1
ii  libconfig-model-dpkg-perl  2.138
ii  libdebian-source-perl      0.113
ii  libdpkg-perl               1.20.5
ii  libemail-address-xs-perl   1.04-1+b2
ii  libemail-date-format-perl  1.005-1
ii  libfile-which-perl         1.23-1
ii  liblist-moreutils-perl     0.416-1+b5
ii  libmodule-depends-perl     0.16-3
ii  libsoftware-license-perl   0.103014-2
ii  libtie-ixhash-perl         1.23-2
ii  libwww-mechanize-perl      2.00-2
ii  libwww-perl                6.47-1
ii  libyaml-libyaml-perl       0.82+repack-1
ii  libyaml-perl               1.30-1
ii  make                       4.3-4
ii  perl [libpod-parser-perl]  5.30.3-4

Versions of packages dh-make-perl recommends:
ii  apt                   2.1.10
ii  apt-file              3.2.2
ii  git                   1:2.28.0-1
ii  libdpkg-parse-perl    0.03-2
ii  libmodule-build-perl  0.423100-1
ii  libsys-cpu-perl       0.61-2+b5
ii  pristine-tar          1.49

dh-make-perl suggests no packages.

-- no debconf information