Bug#971081: pkg-perl-autopkgtest: smoke test and debian/tests/pkg-perl/smoke-tests

[gregor herrmann]

Package: pkg-perl-autopkgtest
Version: 0.62
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

The `smoke' test can use debian/tests/pkg-perl/smoke-tests to decide
which tests are run, but there's an issue.

Example:

libcgi-application-plugin-tt-perl:

% cat debian/tests/pkg-perl/smoke-tests 
t/*.t
lastmodified/t/*.t


But only the 't/*.t' tests are run. Checking with -x in `smoke' this
looks like:

+ pwd
+ tests_file=/home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests
+ cd /home/gregoa/tmp/smokeHCzjlD
+ [ -r /home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests ]
+ egrep -v ^# /home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests
+ eval ls -d t/01_basic.t t/02_error.t t/03_tname.t t/04_singleton.t t/05_include_path.t t/06_callback.t t/07_devpopup.t t/08_load_tmpl.t lastmodified/t/*.t
+ true
+ test_targets=t/01_basic.t
t/02_error.t
t/03_tname.t
t/04_singleton.t
t/05_include_path.t
t/06_callback.t
t/07_devpopup.t
t/08_load_tmpl.t

(in dash, or in bash:)

++ pwd
+ tests_file=/home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests
+ cd /home/gregoa/tmp/smokeX0KrEh
+ '[' -r /home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests ']'
+++ egrep -v '^#' /home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests
++ eval ls -d t/01_basic.t t/02_error.t t/03_tname.t t/04_singleton.t t/05_include_path.t t/06_callback.t t/07_devpopup.t t/08_load_tmpl.t 'lastmodified/t/*.t'
++ true
+ test_targets='t/01_basic.t
t/02_error.t
t/03_tname.t
t/04_singleton.t
t/05_include_path.t
t/06_callback.t
t/07_devpopup.t
t/08_load_tmpl.t'


Interestingly, running the relevant line on the command line is
different:

% files=$(eval ls -d $(egrep -v '^#' /home/gregoa/src/git-pkg-perl/meta/packages/libcgi-application-plugin-tt-perl/debian/tests/pkg-perl/smoke-tests));echo $files
lastmodified/t/auto-last-modified.t
lastmodified/t/last-modified.t
lastmodified/t/plain.t
lastmodified/t/pod-coverage.t
lastmodified/t/pod.t
t/01_basic.t
t/02_error.t
t/03_tname.t
t/04_singleton.t
t/05_include_path.t
t/06_callback.t
t/07_devpopup.t
t/08_load_tmpl.t
t/09_precompile_dir.t
t/98_pod.t
t/99_pod_coverage.t


For the record, the relevant code in `smoke' is:

   152	tests_file=$(pwd)/debian/tests/pkg-perl/smoke-tests
   153	cd $TDIR
   154	if [ -r $tests_file ]; then
   155	    test_targets=$(eval ls -d $(egrep -v '^#' $tests_file) 2>/dev/null || true)
   156	fi


Just some typical shell hiccup I guess :)


Cheers,
gregor

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl9woHxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgbUlQ//Yqxaq0WpCgAiZVRAMDUnjy7vU8CZ8bJgjp5usFsIxIvGG0eenrDM8Ykf
Disu8DeZZP1UN5o/9S1c/jFYflaS6zD52v3tJT8mS5Fwm4YETUwKeZe3sZC2/Ckg
p9N73dXHlaonVOsVFAMDwv3i2FW9EveiuRixvi/SoJ4nUaQteAAjOvwsVEPvFMmm
Zth0ynJtZpsKyMSivDa9zzxbDXvm6g0VvcETaoQas2E2fdKIvWGwIODCQ0FGR1Sk
amBYRyeyfPywEU77Y3Fw9t1ql+e/Q1hbuZHryGO0pWQqQphEFT6puPYLH9NSS/5s
RNVXD1jsROzo6HZkWMJA1E/QQHy9RAtHptR9wsDyAjJAxGh4GpwNv3V8jpBNbrgo
Y09STN02LNnlloyxohfNcqeMkLJfKdfNY9VuUiCXJoU3PxEdINnMrowHSGb/Lkhp
GjZ4nPvK52Im2A8UuwrF8pBB6Mqz9sohwwfL0UdYnf/SI8Zh1liHVqk09FXA58Mb
9gmAmR4E105C3yKML9+pvqrdJFydN6Xuf0Hu4xo8ISmoHXLVeyewYZ4DV9BcuyrW
AJedCQBaS3rmyjcLB8qSEyLBN1vdf7NkwIfwSe1ColSMqE+5Q1Emoyhv7j7s5H9/
U3rLRODxNuw0E+bgSAbMHNF5Oq7DhYXRvinskFoE215zzemOV9Q=
=JwWV
-----END PGP SIGNATURE-----