Bug#981647: libgnupg-interface-perl 1.01 breaks ssh-agent msva-perl ...

[Dominic Hargreaves]

On Sun, Feb 07, 2021 at 11:42:43PM +0000, Dominic Hargreaves wrote:
> [Adding Andrew as the person who has recently worked on the package]
> 
> On Sun, Feb 07, 2021 at 03:28:48PM -0500, Aaron M. Ucko wrote:
> > Dominic Hargreaves <dom at earth.li> writes:
> > 
> > > As a hunch, I changed the default from 'gpg' to '/usr/bin/gpg'.
> > > Could you install this on your system and confirm whether it fixes
> > > the problem?
> 
> (the tentative fix was at
> <https://salsa.debian.org/perl-team/modules/packages/libgnupg-interface-perl/-/tree/hardcode-gpg-path>)
> 
> > I must confess that I haven't actually fully deployed MonkeySphere, so I
> > can't test the change quite as thoroughly as it perhaps deserves, but
> > AFAICT this tweak is sufficient: I can log in without incident, and both
> > dh_auto_test calls to succeed (albeit noisily) with
> > 
> >   -- FULLPERL='/usr/bin/perl -t'
> > 
> > appended.  (Full -T appears to break the test harness, but -t suffices
> > to trigger the PATH-clearing logic.)
> 
> In fact, I've just realised that this regression comes from reverting
> a functionality equivalent (part of a) patch in the latest upload.
> This looks like it might have been unintentional?
> 
> https://salsa.debian.org/perl-team/modules/packages/libgnupg-interface-perl/-/commit/a96ae3047570483e96da309008d4110f16824ed5#f37d120361709f5984c8a7d93302241dc341b4b3_1_1
> 
> Andrew, was this intentional? Maybe we should just restore that part
> of the patch?

Ah, I expect the change to /usr/bin/gpg was lost when applying an
altered upstream version of the patch. So my tentative fix
was correct and just the previous behaviour, with the upstream
changes and the Debian-specific changes now in separate files.
Uploaded.