Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

[Axel Beckert]

Package: lintian-brush
Version: 0.95
Severity: normal

Hi Jelmer,

https://salsa.debian.org/perl-team/modules/packages/equivs/-/commit/30c7e453ca187534ede9449e28e21e8b1a3b01fe
added "Testsuite: autopkgtest-pkg-perl" to equivs, despite a
debian/tests/control file is present in git (so a Testsuite header is
not necessary according to lintian) and the package has nothing which
can be tested via pkg-perl-autopkgtest:

autopkgtest [18:13:11]: test autodep8-perl-build-deps: preparing testbed
autopkgtest [18:13:11]: test autodep8-perl-build-deps: /usr/share/pkg-perl-autopkgtest/runner build-deps
autopkgtest [18:13:11]: test autodep8-perl-build-deps: [-----------------------
I: Nothing to prove, skipping.
autopkgtest [18:13:11]: test autodep8-perl-build-deps: -----------------------]
autopkgtest [18:13:11]: test autodep8-perl-build-deps:  - - - - - - - - - - results - - - - - - - - - -
autodep8-perl-build-deps SKIP exit status 77 and marked as skippable
autopkgtest [18:13:11]: test autodep8-perl: preparing testbed
autopkgtest [18:13:12]: test autodep8-perl: /usr/share/pkg-perl-autopkgtest/runner runtime-deps
autopkgtest [18:13:12]: test autodep8-perl: [-----------------------
/usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t .. skipped: can't guess package from META.json or META.yml
Files=1, Tests=0,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.09 cusr  0.01 csys =  0.12 CPU)
Result: NOTESTS
autopkgtest [18:13:12]: test autodep8-perl: -----------------------]
autopkgtest [18:13:12]: test autodep8-perl:  - - - - - - - - - - results - - - - - - - - - -
autodep8-perl        PASS (superficial)
autopkgtest [18:13:12]: test autodep8-perl-recommends: preparing testbed
autopkgtest [18:13:13]: test autodep8-perl-recommends: /usr/share/pkg-perl-autopkgtest/runner runtime-deps-and-recommends
autopkgtest [18:13:13]: test autodep8-perl-recommends: [-----------------------
/usr/share/pkg-perl-autopkgtest/runtime-deps-and-recommends.d/syntax.t .. 
1..4
ok 1 - Package equivs is known to dpkg
ok 2 - Got status information for package equivs
ok 3 - Got file list for package equivs
ok 4 # skip no perl modules to test in equivs
ok
All tests successful.
Files=1, Tests=4,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.32 cusr  0.07 csys =  0.41 CPU)
Result: PASS
autopkgtest [18:13:14]: test autodep8-perl-recommends: -----------------------]
autopkgtest [18:13:14]: test autodep8-perl-recommends:  - - - - - - - - - - results - - - - - - - - - -
autodep8-perl-recommends PASS (superficial)
autopkgtest [18:13:14]: @@@@@@@@@@@@@@@@@@@@ summary
command1             PASS
autodep8-perl-build-deps SKIP exit status 77 and marked as skippable
autodep8-perl        PASS (superficial)
autodep8-perl-recommends PASS (superficial)
autopkgtest -B ./ --- null  11.37s user 2.18s system 89% cpu 15.206 total

So please stop adding "Testsuite:" headers if debian/tests/control is
already present.

Luckily the testsuite declared in debian/tests/control was still run, so
it didn't completely break autopkgtest for this package, but at least
caused unnecessary tests being tried to run, but then skipped.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-1-amd64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages lintian-brush depends on:
ii  devscripts                   2.20.5
ii  ognibuild                    0.0.1~git20201031.4cbc8df-1.1
ii  python3                      3.9.1-1
ii  python3-breezy               3.1.0-8
ii  python3-debian               0.1.39
ii  python3-debmutate            0.20
ii  python3-distro-info          1.0
ii  python3-dulwich              0.20.15-1
ii  python3-iniparse             0.4-3
ii  python3-ruamel.yaml          0.16.12-2
ii  python3-upstream-ontologist  0.1.9-1

Versions of packages lintian-brush recommends:
ii  decopy               0.2.4.4-0.1
ii  dos2unix             7.4.1-1
ii  gpg                  2.2.27-1
ii  libdebhelper-perl    13.3.3
ii  lintian              2.104.0
pn  python3-asyncpg      <none>
ii  python3-bs4          4.9.3-1
ii  python3-levenshtein  0.12.2-1
ii  python3-pyinotify    0.9.6-1.3
ii  python3-toml         0.10.1-1

Versions of packages lintian-brush suggests:
pn  breezy-debian      <none>
pn  gnome-pkg-tools    <none>
ii  po-debconf         1.0.21+nmu1
pn  postgresql-common  <none>

-- no debconf information