Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

[Jelmer Vernooij]

Hi Axel,

On Mon, Feb 15, 2021 at 08:29:51PM +0100, Axel Beckert wrote:
> Jelmer Vernooij wrote:
> > > So please stop adding "Testsuite:" headers if debian/tests/control is
> > > already present.
> > > 
> > > Luckily the testsuite declared in debian/tests/control was still run, so
> > > it didn't completely break autopkgtest for this package, but at least
> > > caused unnecessary tests being tried to run, but then skipped.
> > Thanks for the bug report.
> > 
> > It looks like this is also a bug in lintian, since it reports
> > team/pkg-perl/testsuite/no-team-tests for equivs:
> > 
> > https://lintian.debian.org/tags/team/pkg-perl/testsuite/no-team-tests.html
> 
> Hmmm, I have recently worked on debsums (similar case of a native
> pkg-perl-team package which also has a debian/tests/control file) and
> I can't remember having seen that warning. Then again I had the
> feeling that the lintian tags on the web are often outdated.
> 
> Just checked: Yeah, it's overridden there. (Overridden by myself in
> 2015. :-)
> 
> But the lintian website is outdated nevertheless. It doesn't list
> debsums 3.0.1 from over 2 months ago and still lists "E
> malformed-override Unknown tag nonteam-testsuite-header in line 3"
> which was the old name of that tag — fixed in the 3.0.1 upload.

Ah, sorry for linking to that - I find it convenient, but
lintian-brush does actually read the overrides file rather than
checking the lintian website except to find unused overrides.

> And yeah, it emits that for equivs as well:
> 
> W: equivs source: team/pkg-perl/testsuite/no-team-tests autopkgtest
> 
> I should probably override that also for equivs. Does lintian-brush
> respect lintian overrides in the meanwhile?
Yep:

% debcheckout equivs
declared git repository at https://salsa.debian.org/perl-team/modules/packages/equivs.git
git clone https://salsa.debian.org/perl-team/modules/packages/equivs.git equivs ...
Cloning into 'equivs'...
remote: Enumerating objects: 608, done.
remote: Counting objects: 100% (608/608), done.
remote: Compressing objects: 100% (266/266), done.
remote: Total 608 (delta 317), reused 573 (delta 292), pack-reused 0
Receiving objects: 100% (608/608), 111.35 KiB | 502.00 KiB/s, done.
Resolving deltas: 100% (317/317), done.
% echo team/pkg-perl/testsuite/no-testsuite-header > debian/source/lintian-overrides
% git add debian/source/lintian-overrides
% git commit -a -m "add override for team/pkg-perl/testsuite/no-testsuite-header"
% lintian-brush
No changes made.

(it should ideally report how many things it didn't do because of
overrides, but that's a TODO)

Cheers,

Jelmer