Bug#991660: unblock: libhttp-cookiejar-perl/0.010-2

Étienne Mollier emollier at emlwks999.eu
Thu Jul 29 20:22:38 BST 2021


Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock

Good day,

Please unblock package libhttp-cookiejar-perl

[ Reason ]
libhttp-cookiejar-perl 0.010-2 fixes #991649; a long standing
test in the suite contained expiry dates which finally went
overdue causing a test failure.

[ Impact ]
If the unblock is not granted, libhttp-cookiejar-perl will FTBFS
and won't make it to bullseye, transitively putting at risk its
reverse (build) dependencies, which are numerous due
libhttp-tiny-perl being one of them.

[ Tests ]
I checked the build time test and autopkgtest were fixed in the
newer version.

[ Risks ]
Risks are probably very low: only the test suite is altered by
the patch.  The change brought made its way to the package in
upstream version 0.011.

[ Checklist ]
  [*] all changes are documented in the d/changelog
  [*] I reviewed all changes and I approve them
  [*] attach debdiff against the package in testing

unblock libhttp-cookiejar-perl/0.010-2

Have a nice day,  :)
-- 
Étienne Mollier <emollier at emlwks999.eu>
Fingerprint:  8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/6, please excuse my verbosity.
-------------- next part --------------
diff -Nru libhttp-cookiejar-perl-0.010/debian/changelog libhttp-cookiejar-perl-0.010/debian/changelog
--- libhttp-cookiejar-perl-0.010/debian/changelog	2020-09-24 21:44:19.000000000 +0200
+++ libhttp-cookiejar-perl-0.010/debian/changelog	2021-07-29 19:32:27.000000000 +0200
@@ -1,3 +1,10 @@
+libhttp-cookiejar-perl (0.010-2) unstable; urgency=medium
+
+  * Team upload.
+  * add postpone-test-expiry.patch from David Golden (Closes: #991649)
+
+ -- Étienne Mollier <emollier at debian.org>  Thu, 29 Jul 2021 19:32:27 +0200
+
 libhttp-cookiejar-perl (0.010-1) unstable; urgency=medium
 
   [ Salvatore Bonaccorso ]
diff -Nru libhttp-cookiejar-perl-0.010/debian/patches/postpone-test-expiry.patch libhttp-cookiejar-perl-0.010/debian/patches/postpone-test-expiry.patch
--- libhttp-cookiejar-perl-0.010/debian/patches/postpone-test-expiry.patch	1970-01-01 01:00:00.000000000 +0100
+++ libhttp-cookiejar-perl-0.010/debian/patches/postpone-test-expiry.patch	2021-07-29 19:25:13.000000000 +0200
@@ -0,0 +1,47 @@
+Description: postpone expiry dates in test suites to 2041
+Author: David Golden
+Origin: upstream, https://github.com/dagolden/HTTP-CookieJar/commit/7a3b9b163526784bf18a69172df736d190c15940
+Bug: https://github.com/dagolden/HTTP-CookieJar/issues/11
+Bug-Debian: https://bugs.debian.org/991649
+Applied-Upstream: 0.011
+Reviewed-by: Étienne Mollier <emollier at debian.org>
+Last-Update: 2021-07-29
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- libhttp-cookiejar-perl.orig/t/examples.t
++++ libhttp-cookiejar-perl/t/examples.t
+@@ -38,7 +38,7 @@
+ 
+ subtest "expiration" => sub {
+     $jar->clear;
+-    $jar->add( $req, "lang=en-US; Expires=Wed, 09 Jun 2021 10:18:14 GMT" );
++    $jar->add( $req, "lang=en-US; Expires=Sun, 09 Jun 2041 10:18:14 GMT" );
+     is( $jar->cookie_header($req), "lang=en-US" );
+     $jar->add( $req, "lang=; Expires=Sun, 06 Nov 1994 08:49:37 GMT" );
+     is( $jar->cookie_header($req), "" );
+--- libhttp-cookiejar-perl.orig/t/parse.t
++++ libhttp-cookiejar-perl/t/parse.t
+@@ -83,19 +83,19 @@
+         }
+     },
+     {
+-        cookie => "lang=en-US; Expires = Wed, 09 Jun 2021 10:18:14 GMT",
++        cookie => "lang=en-US; Expires = Sun, 09 Jun 2041 10:18:14 GMT",
+         parse  => {
+             name    => "lang",
+             value   => "en-US",
+-            expires => 1623233894,
++            expires => 2254385894,
+         }
+     },
+     {
+-        cookie => "lang=en-US; Expires = Wed, 09 Jun 2021 10:18:14 GMT; Max-Age=3600",
++        cookie => "lang=en-US; Expires = Sun, 09 Jun 2041 10:18:14 GMT; Max-Age=3600",
+         parse  => {
+             name      => "lang",
+             value     => "en-US",
+-            expires   => 1623233894,
++            expires   => 2254385894,
+             'max-age' => 3600,
+         }
+     },
diff -Nru libhttp-cookiejar-perl-0.010/debian/patches/series libhttp-cookiejar-perl-0.010/debian/patches/series
--- libhttp-cookiejar-perl-0.010/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libhttp-cookiejar-perl-0.010/debian/patches/series	2021-07-29 19:12:41.000000000 +0200
@@ -0,0 +1 @@
+postpone-test-expiry.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20210729/b21295d6/attachment.sig>


More information about the pkg-perl-maintainers mailing list