Bug#1014720: FTBFS: test failure in t/update_mirror.t

[Lukas Märdian]

Package: libcpan-mini-inject-perl
Version: 0.35-4
Followup-For: Bug #1014720
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch
X-Debbugs-Cc: slyon at ubuntu.com
Control: tags -1 patch

Hi Gregor,

I think using the newer version of liburi-perl (using libregexp-ipv6-perl
dependency) is just hiding the actuall issue.

In Ubuntu we dropped liburi-perl's libregexp-ipv6-perl dependency back to a
Suggests and this issue reappeared. After some investigation, I found an error
in the DIE signal handling of libcpan-mini-inject-perl (in t/update_mirror.t).

See https://github.com/AndyA/CPAN--Mini--Inject/pull/26 for more details.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/ignore-die-in-eval.patch: Fix test failure if Regexp::IPv6 is missing
    (LP: #1981608)

Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-40-generic (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru libcpan-mini-inject-perl-0.35/debian/patches/ignore-die-in-eval.patch libcpan-mini-inject-perl-0.35/debian/patches/ignore-die-in-eval.patch
--- libcpan-mini-inject-perl-0.35/debian/patches/ignore-die-in-eval.patch	1970-01-01 01:00:00.000000000 +0100
+++ libcpan-mini-inject-perl-0.35/debian/patches/ignore-die-in-eval.patch	2022-08-08 17:37:52.000000000 +0200
@@ -0,0 +1,20 @@
+Description: Ignore DIE signal inside eval blocks
+ The process will still be running and the error handled.
+ See: https://www.perlmonks.org/?node_id=1173708
+Author: Lukas M?rdian <slyon at ubuntu.com>
+Forwarded: https://github.com/AndyA/CPAN--Mini--Inject/pull/26
+---
+--- libcpan-mini-inject-perl-0.35.orig/t/update_mirror.t
++++ libcpan-mini-inject-perl-0.35/t/update_mirror.t
+@@ -24,7 +24,10 @@ my $pid    = $server->background;
+ ok( $pid, 'HTTP Server started' );
+ sleep 1;
+ 
+-$SIG{__DIE__} = sub { kill( 9, $pid ) };
++$SIG{__DIE__} = sub {
++  return if $^S; # ignore die in an eval block, while process is still running
++  kill( 9, $pid )
++};
+ 
+ my $mcpi = CPAN::Mini::Inject->new;
+ $mcpi->parsecfg( 't/.mcpani/config' );
diff -Nru libcpan-mini-inject-perl-0.35/debian/patches/series libcpan-mini-inject-perl-0.35/debian/patches/series
--- libcpan-mini-inject-perl-0.35/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libcpan-mini-inject-perl-0.35/debian/patches/series	2022-08-08 17:37:52.000000000 +0200
@@ -0,0 +1 @@
+ignore-die-in-eval.patch