Bug#1017375: liblexical-accessor-perl: test failure with Sub::HandlesVia 0.034

[gregor herrmann]

On Mon, 15 Aug 2022 05:26:39 +0000, Damyan Ivanov wrote:

> t/30shv.t fails with:
> 
> Usage: Sub::HandlesVia::CodeGenerator::method_installer(self) at 
> .../lib/Sub/HandlesVia/Toolkit/SubAccessorSmall.pm line 58.
> 
> In version 0.034, Sub::HandlesVia::CodeGenerator's method_installer field 
> is read-only and the above line tries to modify it:
> 
> 	$gen->method_installer( sub {
> 		my ( $method_name, $coderef ) = @_;
> 		my $real_destination = $handles_map->{$method_name};
> 		$realattr->install_coderef( $real_destination, $coderef );
> 	} );


This should be fixed with libsub-handlesvia-perl 0.035, judging from
the following upstream commit:


commit 8c5799169c61a4c7aec65df51997a42bbecb8bd5
Author: Toby Inkster <mail at tobyinkster.co.uk>
Date:   Fri Aug 12 15:40:49 2022 +0100

    Make the CodeGenerator's method_installer an rw attribute

diff --git a/lib/Sub/HandlesVia/CodeGenerator.pm b/lib/Sub/HandlesVia/CodeGenerator.pm
index c9d353b..586ca9b 100644
--- a/lib/Sub/HandlesVia/CodeGenerator.pm
+++ b/lib/Sub/HandlesVia/CodeGenerator.pm
@@ -156,7 +156,7 @@ has generator_for_type_assertion => (
 );
 
 has method_installer => (
-	is => ro,
+	is => rw,
 	isa => 'CodeRef',
 );
 

Also Changes say:
 - Sub::HandlesVia::CodeGenerator method_installer is now a rw attribute as
   Sub::Accessor::Small was relying on that.


I'm going to upload libsub-handlesvia-perl now, then we can depend on
the fixed version to close this bug, I guess?


Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20220817/b0a08818/attachment.sig>