Bug#1025882: libdatetime-perl ftbfs with new libdatetime-locale-perl

[Steve Langasek]

Package: libdatetime-perl
Version: 2:1.57-2
Severity: serious
Tags: patch
Justification: ftbfs
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu lunar ubuntu-patch

Dear maintainers,

libdatetime-perl currently FTBFS in unstable because a of a test failure
introduced by a new libdatetime-locale-perl:

[...]
    #   Failed test '%c is Sep 7, 1999, 1:02:42 PM'
    #   at t/13strftime.t line 311.
    #          got: 'Sep 7, 1999, 1:02:42<E2><80><AF>PM'
    #     expected: 'Sep 7, 1999, 1:02:42 PM'

    #   Failed test '%X is 1:02:42 PM'
    #   at t/13strftime.t line 311.
    #          got: '1:02:42<E2><80><AF>PM'
    #     expected: '1:02:42 PM'
    # Looks like you failed 2 tests of 49.
[...]

This also shows up as an autopkgtest failure at
<https://ci.debian.net/packages/libd/libdatetime-perl/testing/amd64/>.

I do no know why these format strings are now using a unicode non-breaking
space instead of a space as they were before, but it's simple enough to
update the test suite to match the current output.  Please see attached.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru libdatetime-perl-1.57/debian/patches/series libdatetime-perl-1.57/debian/patches/series
--- libdatetime-perl-1.57/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
+++ libdatetime-perl-1.57/debian/patches/series	2022-12-11 00:31:48.000000000 -0800
@@ -0,0 +1 @@
+strftime-output-change.patch
diff -Nru libdatetime-perl-1.57/debian/patches/strftime-output-change.patch libdatetime-perl-1.57/debian/patches/strftime-output-change.patch
--- libdatetime-perl-1.57/debian/patches/strftime-output-change.patch	1969-12-31 16:00:00.000000000 -0800
+++ libdatetime-perl-1.57/debian/patches/strftime-output-change.patch	2022-12-11 00:34:03.000000000 -0800
@@ -0,0 +1,31 @@
+Description: update test suite for changed strftime output
+ With libdatetime-locale-perl 1.37, en_US locale strings are now using a
+ unicode narrow no-break space instead of a regular space before the AM/PM
+ marker (?!).  Update the test suite to match since this change affects
+ nothing wrt the correctness of this module.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+Last-Update: 2022-12-11
+Forwarded: no
+
+Index: libdatetime-perl-1.57/t/13strftime.t
+===================================================================
+--- libdatetime-perl-1.57.orig/t/13strftime.t
++++ libdatetime-perl-1.57/t/13strftime.t
+@@ -322,7 +322,7 @@
+     my $c_format = $en_locale->datetime_format;
+     $c_format
+         =~ s/\{1\}/$en_locale->month_format_abbreviated->[8] . ' 7, 1999'/e;
+-    $c_format =~ s/\{0\}/'1:02:42 ' . $en_locale->am_pm_abbreviated->[1]/e;
++    $c_format =~ s/\{0\}/'1:02:42?' . $en_locale->am_pm_abbreviated->[1]/e;
+ 
+     return {
+         '%%'        => '%',
+@@ -366,7 +366,7 @@
+         '%w'        => '2',
+         '%W'        => '36',
+         '%x'        => $en_locale->month_format_abbreviated->[8] . ' 7, 1999',
+-        '%X'        => '1:02:42 ' . $en_locale->am_pm_abbreviated->[1],
++        '%X'        => '1:02:42?' . $en_locale->am_pm_abbreviated->[1],
+         '%y'        => '99',
+         '%Y'        => '1999',
+         '%z'        => '+0000',