Bug#1005086: Please package Perl::Critic::Community

[gregor herrmann]

Control: block -1 with 1005239
Control: tag -1 + confirmed

On Sun, 06 Feb 2022 23:00:32 -0800, Russ Allbery wrote:

> Perl::Critic::Freenode has become Perl::Critic::Community, which
> also means that all of the policies that it installs have been
> renamed to Community::* from Freenode::*.

Hi Russ, and fellow oysters,

thanks for bringing this to our attention!
 
> Unfortunately, perlcritic produces a mandatory warning when one
> suppresses an unknown policy in perlcriticrc, which makes this
> awkward.  Since Debian unstable has the old package and old policy
> names, but installing Perl::Critic::Freenode from CPAN (in CI, for
> instance) will install the current version with the Community names,

Oh, right, AFAICS, the new Perl-Critic-Community also ships all files
included in the old Perl-Critic-Freenode distribution (as wrappers),
and the latter is simply gone from MetaCPAN.

I've now created a libperl-critic-community-perl package:
Vcs-Browser: https://salsa.debian.org/perl-team/modules/packages/libperl-critic-community-perl
Vcs-Git: https://salsa.debian.org/perl-team/modules/packages/libperl-critic-community-perl.git
ITP: #1005239

and for the transition / the question of the overlapping files,
there's the following in d/control:

#v+
Breaks: libperl-critic-freenode-perl (<< 1.0.0)
Replaces: libperl-critic-freenode-perl (<< 1.0.0)
Provides: libperl-critic-freenode-perl (= ${binary:Version})
#v-

Breaks+Replaces because "migration"/takeover of files, 1.0.0 as this
is the upstream version of the rename, the Provides because there are
two build/autopkgtest reverse dependencies, and the binary:Version as
the modules have the same upstream version "inside".

A manual install of libperl-critic-community-perl in a chroot looks good:
#v+
The following packages will be REMOVED:
  libperl-critic-freenode-perl
The following NEW packages will be installed:
  libperl-critic-community-perl
0 upgraded, 1 newly installed, 1 to remove and 0 not upgraded.
#v-

I'd just like to have another pair of eyes in case I missed something
and before creating a mess :)

And a question: Do we need a last upload of
libperl-critic-freenode-perl, changing it into a transitional dummy
package depending on libperl-critic-community-perl? I guess yes,
otherwise the 11 users (popcon votes) minus Russ will miss this
change :)


(I guess _this_ bug report against libperl-critic-freenode-perl can
be closed in a last upload.)


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20220209/158fb6bd/attachment-0001.sig>